Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : Adding a tag for a run of the connector #66

Open
AmineI opened this issue Feb 7, 2024 · 3 comments
Open

Feature Request : Adding a tag for a run of the connector #66

AmineI opened this issue Feb 7, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@AmineI
Copy link
Contributor

AmineI commented Feb 7, 2024

Hi,
One of the features of the official firefly iii data importer is to be able to set a specific tag for all the transactions in an import.

For example, if I run the importer today, on 07/02/2024 at 13:19, all transaction imported that run are tagged [Data Import on 2024-02-07 @ 13:19]. You can optionally customize the name of the tag used instead of this default format. All transactions could be tagged "Plaid_import" for example. This would allow for more advanced rules on the imported transactions, to adjust them as needed.

Could such a feature be implemented on this connector as well, in batch and/or poll mode ?

Thanks for your work on this project, looking forward to digging into the code while I get a Plaid account approved :) !

@dvankley
Copy link
Owner

dvankley commented Feb 7, 2024

@AmineI that seems like a reasonable feature request. I'll add it to my list, although fair warning it may take a while.

Any other tokens you want available in the tag aside from date and time?

@AmineI
Copy link
Contributor Author

AmineI commented Feb 15, 2024

Thanks for your answer - of course, it's a hobby/community project so it's not expected to be our priority !

Nothing comes to mind besides date and time. Name of the bank can easily be obtained from the transaction themselves for example.

@dvankley dvankley added the enhancement New feature or request label Feb 18, 2024
@AmineI
Copy link
Contributor Author

AmineI commented Feb 26, 2024

I've become a bit more familiar with your code. I'm not an expert in Kotlin or Spring boot, but I've forked your project and implemented a basic MVP.

main...AmineI:firefly-plaid-connector-2:tags

I realize it is not as flexible as you envisioned (when you mentioned tokens), so I didn't submit a PR for now. Just sharing in case a developer or user can leverage this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants