Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Looking Glass JSON roundtrip #10

Open
ramirez7 opened this issue Aug 13, 2023 · 3 comments
Open

Make Looking Glass JSON roundtrip #10

ramirez7 opened this issue Aug 13, 2023 · 3 comments
Assignees

Comments

@ramirez7
Copy link
Collaborator

Right now, we lose information such as the color of the nodes. If we preserve those through transformations, then things like filtering etc could also be subcommands in addition to options during generation.

@ramirez7 ramirez7 self-assigned this Aug 13, 2023
@ramirez7
Copy link
Collaborator Author

Alternatively, maybe our main format should just be one we own.

@dustin
Copy link
Owner

dustin commented Aug 14, 2023

Yeah, in an older version, there was a bit more structure, but it didn't seem necessary. Building some values that can contain attributes again independently of the links is doable. It could also just be a sparse node-attributes map and maybe an edge map. Otherwise, fall back to the Data.Graph inspired design.

@dustin
Copy link
Owner

dustin commented Sep 4, 2023

The looking glass stuff is getting just a bit weird. It's got a set of attributes attached per-node, but the color isn't one of them. It wouldn't be hard to special case that, I guess.

There's also the title, which would could store as an attribute of "" as the overall document. Kind of a hack, but Doing It Right seems like a lot of work that doesn't really help all that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants