Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: Add Address and Transaction Information #2704

Open
nortonandreev opened this issue Oct 18, 2024 · 2 comments
Open

explorer: Add Address and Transaction Information #2704

nortonandreev opened this issue Oct 18, 2024 · 2 comments
Labels
module:explorer Issues related to explorer module need:breakdown Call for participation: issue too big to solve as is need:feedback Call for participation: feedback is requested to fix this issue need:specs Call for participation: specs are requested to fix this issue type:feature implementing a new feature

Comments

@nortonandreev
Copy link
Contributor

Description

It has been suggested that the Explorer should contain detailed information about addresses and their associated transactions. With the introduction of Moonlight (which is fully public), this functionality should now be possible.

Expected Functionality

  • The Explorer should provide information about addresses and their transactions, similar to the way it is done on Etherscan (e.g., example link).
  • Apart from transactions, Etherscan also provides:
    • Token Transfers
    • Produced Blocks
    • Analysis of the account
  • Additionally, it includes a page that lists the top accounts by ETH balance (example link).

Considerations

  • Review what information is relevant and useful for our users and determine which features make sense to implement for the Dusk Explorer.
  • Create appropriate designs for the updated Explorer views.
  • Ensure there is an API (e.g., w3sper SDK) available to retrieve the necessary data for the new features.

Tasks

  1. Research which Etherscan features are relevant for our Explorer.
  2. Confirm data retrieval is possible through an appropriate API (such as the w3sper SDK).
  3. Design and propose the layout for these features in our Explorer.
  4. Implement and test the new Explorer functionality.

References

@nortonandreev nortonandreev added module:explorer Issues related to explorer module need:specs Call for participation: specs are requested to fix this issue type:feature implementing a new feature need:feedback Call for participation: feedback is requested to fix this issue need:breakdown Call for participation: issue too big to solve as is labels Oct 18, 2024
@deuch13 deuch13 self-assigned this Oct 21, 2024
@deuch13
Copy link
Contributor

deuch13 commented Oct 22, 2024

With the current state of the moonlight history feature querying the endpoint returns an array of objects containing the events found on a block. In the way the information is presented we can only display the block height where the transaction occurred, the type of transaction and the transaction hash. The rest of the information is being returned as bytes in the data property.

Another limitation is that we will have to make two API queries, one for the outbound events and another for the inbound events, which will make displaying the information difficult as the user will not be able to see both inbound and outbound events on the same table.

At this time neither testnet.nodes.dusk.network or devnet.nodes.dusk.network have this feature enabled.

Here is an example of a block returned by the endpoint:

{
"block_height": 19071,
 "events": [
   {
     "data": "00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000e27ba14d672c50a57c493b3774a91211aae4ba7167bac9a145f94dca09b901717b11a8819299536c30f67506e60b2d02990cc165d9bb0b42eaa709cc41fa5c68af1996eee799d949561cfdd24aaf12ef61b535fae5c3a17097733febbf47d2087d673efdf7d3cf7404c0a28300d373c820d6f3169db6609dd54536088585a3ca425a9dec41fb79a5240fb2ec603c170132e8c0497f39556f0d59fa3273c8fed4c0a1f688a310c80122e1789aae4cda7b86a3fccc69a8f469b33b374bd8e2f5140000000000000000000000000000000088fdffff00000000007ddaac00000000",
     "target": "0100000000000000000000000000000000000000000000000000000000000000",
     "topic": "moonlight"
  }],
"origin": "12ace1c345d4677048ac8b0b46fe644d4ea312c66a06b48d9dce8f668a370620"
}

            

@deuch13
Copy link
Contributor

deuch13 commented Oct 22, 2024

After a discussion with @Neotamandua we agreed, as a temporary measure, to create another endpoint which will have all known events byte data deserialized.

@deuch13 deuch13 removed their assignment Oct 29, 2024
@kieranhall kieranhall changed the title explorer: Add Address and Transaction Information to Explorer explorer: Add Address and Transaction Information Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:explorer Issues related to explorer module need:breakdown Call for participation: issue too big to solve as is need:feedback Call for participation: feedback is requested to fix this issue need:specs Call for participation: specs are requested to fix this issue type:feature implementing a new feature
Projects
None yet
Development

No branches or pull requests

2 participants