New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay Buffer Deletion: Random #41

Open

Electro707 opened this issue Apr 10, 2022 · 0 comments

Electro707 commented Apr 10, 2022

In the replay buffer class, when the buffer is full a random sample is deleted:

challenge-aido_LF-baseline-RL-sim-pytorch/duckietown_rl/utils.py

Line 28 in ec2fafb

self.storage.pop(random.randrange(len(self.storage)))

Which goes against DDPG's paper, where

When the replay buffer was full the oldest samples were discarded.

Source: https://arxiv.org/pdf/1509.02971.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment