Target Android 15 (SDK 35) #5204
Draft
+47
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikescamell
force-pushed
the
feature/mike/android-15
branch
from
cf0972a
to
9e35dd9
Compare
we can tackle this at a later date
The dependency has moved to a new repo: https://github.com/sqlcipher/sqlcipher-android
SupportFactory -> SupportOpenHelperFactory
It's false by default and was only added as protection. Since SQLCipher has supported sqlite 3.26.0 since 4.0.1 (released 2018) this should no longer be a concern in my opinion: https://www.zetetic.net/blog/2018/12/18/sqlcipher-401-release/
"The List type in Java is mapped to the MutableList type in Kotlin. Because the List.removeFirst() and List.removeLast() APIs have been introduced in Android 15 (API level 35), the Kotlin compiler resolves function calls, for example list.removeFirst(), statically to the new List APIs instead of to the extension functions in kotlin-stdlib." Robolectric supports 34 right now so easier that we just change these functions.
The function in this class was not used but we can rename it and use it as it uses the removeAt function which we need due to the collision with the stdlib.
This version supports sdk 35: https://github.com/robolectric/robolectric/releases/tag/robolectric-4.14
mikescamell
force-pushed
the
feature/mike/android-15
branch
from
9e35dd9
to
ed1c9a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1206705314358009/f
Description
Waiting on an update to Flipper for 16KB page sizes
Steps to test this PR
UI changes
N/A