Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make InsertTupleIntoChunk more efficient #402

Closed
JelteF opened this issue Nov 7, 2024 · 2 comments
Closed

Make InsertTupleIntoChunk more efficient #402

JelteF opened this issue Nov 7, 2024 · 2 comments
Labels
good first issue Good for newcomers performance We need more speed refactoring Making code more readable
Milestone
0.3.0

Comments

@JelteF
Copy link
Collaborator

JelteF commented Nov 7, 2024 •
edited
Loading

Description

While renaming variables I think we should be able to simplify the InsertTupleIntoChunk code a bit. In at least two ways:

  1. the values array only needs to contain the values that we actually need to output, now it also contains values that we only need to filter on
  2. We now detoast variables twice if they are both part of a filter and one of the output variables. Doing it once should be enough.
@JelteF JelteF added performance We need more speed refactoring Making code more readable labels Nov 7, 2024
@JelteF JelteF added this to the 0.3.0 milestone Nov 7, 2024
@JelteF JelteF added the good first issue Good for newcomers label Nov 7, 2024
@Reminiscent
Copy link
Contributor

Reminiscent commented Nov 9, 2024 •
edited
Loading

I'd like to try this

@Reminiscent Reminiscent mentioned this issue Nov 11, 2024
Closed
@JelteF
Copy link
Collaborator Author

JelteF commented Dec 18, 2024 •
edited
Loading

Closing this in favor of #477, which removes this code completely.

@JelteF JelteF closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers performance We need more speed refactoring Making code more readable
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Make InsertTupleIntoChunk more efficient Reminiscent/pg_duckdb
2 participants
@JelteF @Reminiscent