Use AddStringOrBlob to create to duckdb string from blob value

mkaruza · mkaruza · commit 8ff85e743158 · 2025-01-08T09:23:33.000+01:00
To construct output string use`AddStringOrBlob` which
doesn't require that input is valid UTF8.
diff --git a/src/pgduckdb_types.cpp b/src/pgduckdb_types.cpp
@@ -1268,7 +1268,7 @@ ConvertPostgresToDuckValue(Oid attr_type, Datum value, duckdb::Vector &result, i
 		size_t bytea_length = VARSIZE_ANY_EXHDR(value);
 		const duckdb::string_t s(bytea_data, bytea_length);
 		auto data = duckdb::FlatVector::GetData<duckdb::string_t>(result);
-		data[offset] = duckdb::StringVector::AddString(result, s);
+		data[offset] = duckdb::StringVector::AddStringOrBlob(result, s);
 		break;
 	}
 	case duckdb::LogicalTypeId::LIST: {

Original file line number	Diff line number	Diff line change
`@@ -1268,7 +1268,7 @@ ConvertPostgresToDuckValue(Oid attr_type, Datum value, duckdb::Vector &result, i`
`1268`	`1268`	`size_t bytea_length = VARSIZE_ANY_EXHDR(value);`
`1269`	`1269`	`const duckdb::string_t s(bytea_data, bytea_length);`
`1270`	`1270`	`auto data = duckdb::FlatVector::GetData<duckdb::string_t>(result);`
`1271`		`- data[offset] = duckdb::StringVector::AddString(result, s);`
	`1271`	`+ data[offset] = duckdb::StringVector::AddStringOrBlob(result, s);`
`1272`	`1272`	`break;`
`1273`	`1273`	`}`
`1274`	`1274`	`case duckdb::LogicalTypeId::LIST: {`