Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone conversion is not working for POSIXct datetimes. #206

Open
cy-james-lee opened this issue Jul 31, 2024 · 1 comment
Open

Timezone conversion is not working for POSIXct datetimes. #206

cy-james-lee opened this issue Jul 31, 2024 · 1 comment
Labels
reprex needs a minimal reproducible example

Comments

@cy-james-lee
Copy link

Currently, the timezone_out and tz_out_convert options are supposed to convert date time columns with target timezones. But it is not converting any POSIXct columns.

I think the problem is the following code is supposed to find datetime columns but it's only checking "POSIXt", not "POSIXct".

is_datetime <- which(vapply(x, inherits, "POSIXt", FUN.VALUE = logical(1)))

If "POSIXt" is changed to c("POSIXt", "POSIXct"), it should capture both.

@krlmlr
Copy link
Collaborator

krlmlr commented Aug 16, 2024

Thanks. Can you please share a full reproducible example?

@krlmlr krlmlr added the reprex needs a minimal reproducible example label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reprex needs a minimal reproducible example
Projects
None yet
Development

No branches or pull requests

2 participants