From 868a578638cb70449ae123ffdd731668666991f2 Mon Sep 17 00:00:00 2001 From: Jeff Raymakers Date: Sun, 30 Jun 2024 13:28:16 -0700 Subject: [PATCH] try adding double quotes to zip url --- alt/bindings/binding.gyp | 6 +++--- alt/bindings/scripts/fetch_libduckdb.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/alt/bindings/binding.gyp b/alt/bindings/binding.gyp index fe6b7e03..a65d75a5 100644 --- a/alt/bindings/binding.gyp +++ b/alt/bindings/binding.gyp @@ -6,17 +6,17 @@ 'conditions': [ ['OS=="linux"', { 'variables': { - 'zip_url': 'https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-linux-amd64.zip', + 'zip_url': '"https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-linux-amd64.zip"', }, }], ['OS=="mac"', { 'variables': { - 'zip_url': 'https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-osx-universal.zip', + 'zip_url': '"https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-osx-universal.zip"', }, }], ['OS=="win"', { 'variables': { - 'zip_url': 'https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-windows-amd64.zip', + 'zip_url': '"https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-windows-amd64.zip"', }, }], ], diff --git a/alt/bindings/scripts/fetch_libduckdb.py b/alt/bindings/scripts/fetch_libduckdb.py index 0814b4dc..2106abd0 100644 --- a/alt/bindings/scripts/fetch_libduckdb.py +++ b/alt/bindings/scripts/fetch_libduckdb.py @@ -31,7 +31,7 @@ urllib.request.urlretrieve(libduckdb_zip_url, libduckdb_zip_path) zip = zipfile.ZipFile(libduckdb_zip_path) -print("extracting: " + zip.namelist()) +print("extracting: " + ", ".join(zip.namelist())) zip.extractall(output_dir) # for file_name in libduckdb_file_names: