Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warnings #48

Open
Tishj opened this issue Apr 4, 2024 · 0 comments
Open

Compiler warnings #48

Tishj opened this issue Apr 4, 2024 · 0 comments

Comments

@Tishj
Copy link
Collaborator

Tishj commented Apr 4, 2024

/__w/duckdb/duckdb/build/release/_deps/iceberg_extension_fc-src/src/include/iceberg_types.hpp: In function ‘std::string duckdb::IcebergManifestContentTypeToString(duckdb::IcebergManifestContentType)’:
Warning: /__w/duckdb/duckdb/build/release/_deps/iceberg_extension_fc-src/src/include/iceberg_types.hpp:30:1: warning: control reaches end of non-void function [-Wreturn-type]
   30 | }
      | ^
/__w/duckdb/duckdb/build/release/_deps/iceberg_extension_fc-src/src/include/iceberg_types.hpp: In function ‘std::string duckdb::IcebergManifestEntryStatusTypeToString(duckdb::IcebergManifestEntryStatusType)’:
Warning: /__w/duckdb/duckdb/build/release/_deps/iceberg_extension_fc-src/src/include/iceberg_types.hpp:43:1: warning: control reaches end of non-void function [-Wreturn-type]
   43 | }
      | ^
/__w/duckdb/duckdb/build/release/_deps/iceberg_extension_fc-src/src/include/iceberg_types.hpp: In function ‘std::string duckdb::IcebergManifestEntryContentTypeToString(duckdb::IcebergManifestEntryContentType)’:
Warning: /__w/duckdb/duckdb/build/release/_deps/iceberg_extension_fc-src/src/include/iceberg_types.hpp:56:1: warning: control reaches end of non-void function [-Wreturn-type]
   56 | }

Probably want to add a default: throw InternalException(...) to silence these warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant