Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Toggle on isolatedDeclarations flag on the project #5136

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

🔧 Toggle on isolatedDeclarations flag on the project #5136

wants to merge 14 commits into from

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jul 16, 2024

Description

Fixes #5057

Checklist — Don't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: Configuration update on build side
  • Impacts: Safer build

@dubzzz
Copy link
Owner Author

dubzzz commented Jul 22, 2024 •
edited
Loading

Probably have to wait for microsoft/TypeScript#58771 and/or microsoft/TypeScript#58829, as discussed in https://x.com/ndubien/status/1813361689238335668?t=o2hcjF9X67AcJuSXIJ-VYA&s=19

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Aug 10, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 37f4da0:

Sandbox Source
@fast-check/examples Configuration

@codecov Codecov
Copy link

codecov bot commented Aug 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (7fa7852) to head (37f4da0).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5136   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files         234      234           
  Lines       10414    10414           
  Branches     2773     2774    +1     
=======================================
  Hits         9927     9927           
  Misses        487      487
Flag Coverage Δ
unit-tests 95.32% <ø> (ø)
unit-tests-18.x-Linux 95.32% <ø> (ø)
unit-tests-20.x-Linux 95.32% <ø> (ø)
unit-tests-22.x-Linux 95.32% <ø> (ø)
unit-tests-latest-Linux 95.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz

This comment was marked as outdated.

Sign in to view
@dubzzz
Copy link
Owner Author

dubzzz commented Aug 11, 2024

Waiting for microsoft/rushstack#4877

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: 37f4da0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isolatedDeclarations
1 participant
@dubzzz