🔥 Drop unneeded catch param

dubzzz · web-flow · commit c3e159bdabe3 · 2024-09-23T21:54:22.000Z
There is no more need to specify anything when catching an error without treating it. Let's adopt "Optional catch binding" in our codebase! Available since Node 10. Related to #5282 **Important** - Once reaching next-3.23.0, we should add back the eslint configuration: `'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_', caughtErrors: 'none' }],`.
diff --git a/packages/fast-check/src/arbitrary/_internals/helpers/SlicesForStringBuilder.ts b/packages/fast-check/src/arbitrary/_internals/helpers/SlicesForStringBuilder.ts
@@ -38,7 +38,7 @@ function computeCandidateString(
   let candidate: string[];
   try {
     candidate = stringSplitter(dangerous);
-  } catch (err) {
+  } catch {
     // No split found for `dangerous`, `dangerous` cannot be shrunk by arrays made of `charArbitrary`
     return undefined;
   }
diff --git a/packages/fast-check/src/check/arbitrary/definition/Arbitrary.ts b/packages/fast-check/src/check/arbitrary/definition/Arbitrary.ts
@@ -273,7 +273,7 @@ class MapArbitrary<T, U> extends Arbitrary<U> {
       try {
         const unmapped = this.unmapper(value);
         return this.arb.canShrinkWithoutContext(unmapped);
-      } catch (_err) {
+      } catch {
         return false;
       }
     }
diff --git a/packages/fast-check/src/utils/apply.ts b/packages/fast-check/src/utils/apply.ts
@@ -11,7 +11,7 @@ function safeExtractApply<T, TArgs extends unknown[], TReturn>(
 ): ((thisArg: T) => TReturn) | undefined {
   try {
     return f.apply;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
diff --git a/packages/fast-check/src/utils/globals.ts b/packages/fast-check/src/utils/globals.ts
@@ -65,77 +65,77 @@ const untouchedEvery = Array.prototype.every;
 function extractForEach(instance: unknown[]) {
   try {
     return instance.forEach;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractIndexOf(instance: readonly unknown[]) {
   try {
     return instance.indexOf;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractJoin(instance: unknown[]) {
   try {
     return instance.join;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractMap(instance: unknown[]) {
   try {
     return instance.map;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractFilter(instance: unknown[]) {
   try {
     return instance.filter;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractPush(instance: unknown[]) {
   try {
     return instance.push;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractPop(instance: unknown[]) {
   try {
     return instance.pop;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractSplice(instance: unknown[]) {
   try {
     return instance.splice;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractSlice(instance: unknown[]) {
   try {
     return instance.slice;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractSort(instance: unknown[]) {
   try {
     return instance.sort;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractEvery(instance: unknown[]) {
   try {
     return instance.every;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
@@ -219,14 +219,14 @@ const untouchedToISOString = Date.prototype.toISOString;
 function extractGetTime(instance: Date) {
   try {
     return instance.getTime;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractToISOString(instance: Date) {
   try {
     return instance.toISOString;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
@@ -249,7 +249,7 @@ const untouchedAdd = Set.prototype.add;
 function extractAdd(instance: Set<unknown>) {
   try {
     return instance.add;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
@@ -274,63 +274,63 @@ const untouchedReplace: (pattern: RegExp | string, replacement: string) => strin
 function extractSplit(instance: string) {
   try {
     return instance.split;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractStartsWith(instance: string) {
   try {
     return instance.startsWith;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractEndsWith(instance: string) {
   try {
     return instance.endsWith;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractSubstring(instance: string) {
   try {
     return instance.substring;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractToLowerCase(instance: string) {
   try {
     return instance.toLowerCase;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractToUpperCase(instance: string) {
   try {
     return instance.toUpperCase;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractPadStart(instance: string) {
   try {
     return instance.padStart;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractCharCodeAt(instance: string) {
   try {
     return instance.charCodeAt;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
 function extractReplace(instance: string) {
   try {
     return instance.replace;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
@@ -404,7 +404,7 @@ const untouchedNumberToString = Number.prototype.toString;
 function extractNumberToString(instance: number) {
   try {
     return instance.toString;
-  } catch (err) {
+  } catch {
     return undefined;
   }
 }
diff --git a/packages/fast-check/src/utils/stringify.ts b/packages/fast-check/src/utils/stringify.ts
@@ -157,7 +157,7 @@ function stringifyInternal<Ts>(
     // if user defined custom sync serialization function, we use it before next ones
     try {
       return value[toStringMethod]();
-    } catch (err) {
+    } catch {
       // fallback to defaults...
     }
   }
@@ -212,7 +212,7 @@ function stringifyInternal<Ts>(
           // Instance (or one of its parent prototypes) overrides the default toString of Object
           return (value as any).toString(); // <-- Can throw
         }
-      } catch (err) {
+      } catch {
         // Only return what would have been the default toString on Object
         return '[object Object]';
       }
diff --git a/packages/fast-check/test/e2e/NoRegression.spec.ts b/packages/fast-check/test/e2e/NoRegression.spec.ts
@@ -788,7 +788,7 @@ describe(`NoRegression`, () => {
               try {
                 fc.modelRun(setup, cmds);
                 return true;
-              } catch (err) {
+              } catch {
                 return false;
               }
             },
diff --git a/packages/fast-check/test/e2e/NoStackOverflowOnShrink.spec.ts b/packages/fast-check/test/e2e/NoStackOverflowOnShrink.spec.ts
@@ -12,7 +12,7 @@ const computeMaximalStackSize = () => {
   };
   try {
     f();
-  } catch (_err) {
+  } catch {
     // throws 'RangeError: Maximum call stack size exceeded'
   }
   return depth;
diff --git a/packages/fast-check/test/e2e/Poisoning.spec.ts b/packages/fast-check/test/e2e/Poisoning.spec.ts
@@ -175,7 +175,7 @@ function dropAllFromObj(obj: unknown): (() => void)[] {
       const descriptor = safeObjectGetOwnPropertyDescriptor(obj, k)!;
       delete (obj as any)[k];
       restores.push(() => safeObjectDefineProperty(obj, k, descriptor));
-    } catch (err) {
+    } catch {
       // Object.prototype cannot be deleted, and others might too
     }
   }
diff --git a/packages/fast-check/test/e2e/ReplayFailures.spec.ts b/packages/fast-check/test/e2e/ReplayFailures.spec.ts
@@ -60,7 +60,7 @@ describe(`ReplayFailures (seed: ${seed})`, () => {
             expect(data).toEqual(out.counterexample![0]);
             validCallIndex = numCalls;
             ++numValidCalls;
-          } catch (err) {
+          } catch {
             // noop
           }
           ++numCalls;
diff --git a/packages/fast-check/test/e2e/arbitraries/ObjectArbitrary.spec.ts b/packages/fast-check/test/e2e/arbitraries/ObjectArbitrary.spec.ts
@@ -30,7 +30,7 @@ describe(`ObjectArbitrary (seed: ${seed})`, () => {
           try {
             JSON.parse(revJson(json));
             return false;
-          } catch (err) {
+          } catch {
             return true;
           }
         }),
diff --git a/packages/fast-check/test/unit/arbitrary/__test-helpers__/ArbitraryAssertions.ts b/packages/fast-check/test/unit/arbitrary/__test-helpers__/ArbitraryAssertions.ts
@@ -234,7 +234,7 @@ export function assertProduceSomeSpecificValues<T, U = never>(
       // We default numRuns to 1000, but let user override it whenever needed
       assertParameters: { numRuns: 1000, ...options.assertParameters, endOnFailure: true },
     });
-  } catch (err) {
+  } catch {
     // no-op
   }
   expect(foundOne).toBe(true);
diff --git a/packages/fast-check/test/unit/arbitrary/_internals/builders/AnyArbitraryBuilder.spec.ts b/packages/fast-check/test/unit/arbitrary/_internals/builders/AnyArbitraryBuilder.spec.ts
@@ -224,7 +224,7 @@ function isStringified(v: unknown): boolean {
   try {
     eval(v);
     return true; // the string was correctly parsed
-  } catch (err) {
+  } catch {
     return false; // not a valid representation
   }
 }
@@ -237,7 +237,7 @@ function isStringifiedAsKeys(v: unknown): boolean {
     try {
       eval(key);
       return true; // the string used as key the string representation of a JavaScript instance
-    } catch (err) {
+    } catch {
       // not a valid representation
     }
   }
diff --git a/packages/fast-check/test/unit/arbitrary/commands.spec.ts b/packages/fast-check/test/unit/arbitrary/commands.spec.ts
@@ -25,7 +25,7 @@ describe('commands (integration)', () => {
       if (!c.check(model)) continue;
       try {
         c.run(model, real);
-      } catch (err) {
+      } catch {
         return;
       }
     }
diff --git a/packages/fast-check/test/unit/arbitrary/stringMatching.spec.ts b/packages/fast-check/test/unit/arbitrary/stringMatching.spec.ts
@@ -77,7 +77,7 @@ function regexBasedOnChunks(): fc.Arbitrary<Extra> {
     try {
       new RegExp('.', 'd'); // Not supported in Node 14
       return true;
-    } catch (err) {
+    } catch {
       return false;
     }
   })();
diff --git a/packages/fast-check/test/unit/utils/stringify.spec.ts b/packages/fast-check/test/unit/utils/stringify.spec.ts
@@ -19,7 +19,7 @@ const checkEqual = (a: any, b: any): boolean => {
   try {
     expect(a).toEqual(b);
     return true;
-  } catch (err) {
+  } catch {
     return false;
   }
 };
diff --git a/packages/poisoning/test/main.spec.ts b/packages/poisoning/test/main.spec.ts
@@ -119,7 +119,7 @@ describe('assertNoPoisoning', () => {
           // @ts-ignore
           delete obj[k];
           ++numDeleted;
-        } catch (err) {
+        } catch {
           // Object.prototype cannot be deleted, and others might too
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ function computeCandidateString(`
`38`	`38`	`let candidate: string[];`
`39`	`39`	`try {`
`40`	`40`	`candidate = stringSplitter(dangerous);`
`41`		`- } catch (err) {`
	`41`	`+ } catch {`
`42`	`42`	// No split found for `dangerous`, `dangerous` cannot be shrunk by arrays made of `charArbitrary`
`43`	`43`	`return undefined;`
`44`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ class MapArbitrary<T, U> extends Arbitrary<U> {`
`273`	`273`	`try {`
`274`	`274`	`const unmapped = this.unmapper(value);`
`275`	`275`	`return this.arb.canShrinkWithoutContext(unmapped);`
`276`		`- } catch (_err) {`
	`276`	`+ } catch {`
`277`	`277`	`return false;`
`278`	`278`	`}`
`279`	`279`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ function safeExtractApply<T, TArgs extends unknown[], TReturn>(`
`11`	`11`	`): ((thisArg: T) => TReturn) \| undefined {`
`12`	`12`	`try {`
`13`	`13`	`return f.apply;`
`14`		`- } catch (err) {`
	`14`	`+ } catch {`
`15`	`15`	`return undefined;`
`16`	`16`	`}`
`17`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,77 +65,77 @@ const untouchedEvery = Array.prototype.every;`
`65`	`65`	`function extractForEach(instance: unknown[]) {`
`66`	`66`	`try {`
`67`	`67`	`return instance.forEach;`
`68`		`- } catch (err) {`
	`68`	`+ } catch {`
`69`	`69`	`return undefined;`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`	`function extractIndexOf(instance: readonly unknown[]) {`
`73`	`73`	`try {`
`74`	`74`	`return instance.indexOf;`
`75`		`- } catch (err) {`
	`75`	`+ } catch {`
`76`	`76`	`return undefined;`
`77`	`77`	`}`
`78`	`78`	`}`
`79`	`79`	`function extractJoin(instance: unknown[]) {`
`80`	`80`	`try {`
`81`	`81`	`return instance.join;`
`82`		`- } catch (err) {`
	`82`	`+ } catch {`
`83`	`83`	`return undefined;`
`84`	`84`	`}`
`85`	`85`	`}`
`86`	`86`	`function extractMap(instance: unknown[]) {`
`87`	`87`	`try {`
`88`	`88`	`return instance.map;`
`89`		`- } catch (err) {`
	`89`	`+ } catch {`
`90`	`90`	`return undefined;`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`	`function extractFilter(instance: unknown[]) {`
`94`	`94`	`try {`
`95`	`95`	`return instance.filter;`
`96`		`- } catch (err) {`
	`96`	`+ } catch {`
`97`	`97`	`return undefined;`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`	`function extractPush(instance: unknown[]) {`
`101`	`101`	`try {`
`102`	`102`	`return instance.push;`
`103`		`- } catch (err) {`
	`103`	`+ } catch {`
`104`	`104`	`return undefined;`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`	`function extractPop(instance: unknown[]) {`
`108`	`108`	`try {`
`109`	`109`	`return instance.pop;`
`110`		`- } catch (err) {`
	`110`	`+ } catch {`
`111`	`111`	`return undefined;`
`112`	`112`	`}`
`113`	`113`	`}`
`114`	`114`	`function extractSplice(instance: unknown[]) {`
`115`	`115`	`try {`
`116`	`116`	`return instance.splice;`
`117`		`- } catch (err) {`
	`117`	`+ } catch {`
`118`	`118`	`return undefined;`
`119`	`119`	`}`
`120`	`120`	`}`
`121`	`121`	`function extractSlice(instance: unknown[]) {`
`122`	`122`	`try {`
`123`	`123`	`return instance.slice;`
`124`		`- } catch (err) {`
	`124`	`+ } catch {`
`125`	`125`	`return undefined;`
`126`	`126`	`}`
`127`	`127`	`}`
`128`	`128`	`function extractSort(instance: unknown[]) {`
`129`	`129`	`try {`
`130`	`130`	`return instance.sort;`
`131`		`- } catch (err) {`
	`131`	`+ } catch {`
`132`	`132`	`return undefined;`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`	`function extractEvery(instance: unknown[]) {`
`136`	`136`	`try {`
`137`	`137`	`return instance.every;`
`138`		`- } catch (err) {`
	`138`	`+ } catch {`
`139`	`139`	`return undefined;`
`140`	`140`	`}`
`141`	`141`	`}`
`@@ -219,14 +219,14 @@ const untouchedToISOString = Date.prototype.toISOString;`
`219`	`219`	`function extractGetTime(instance: Date) {`
`220`	`220`	`try {`
`221`	`221`	`return instance.getTime;`
`222`		`- } catch (err) {`
	`222`	`+ } catch {`
`223`	`223`	`return undefined;`
`224`	`224`	`}`
`225`	`225`	`}`
`226`	`226`	`function extractToISOString(instance: Date) {`
`227`	`227`	`try {`
`228`	`228`	`return instance.toISOString;`
`229`		`- } catch (err) {`
	`229`	`+ } catch {`
`230`	`230`	`return undefined;`
`231`	`231`	`}`
`232`	`232`	`}`
`@@ -249,7 +249,7 @@ const untouchedAdd = Set.prototype.add;`
`249`	`249`	`function extractAdd(instance: Set<unknown>) {`
`250`	`250`	`try {`
`251`	`251`	`return instance.add;`
`252`		`- } catch (err) {`
	`252`	`+ } catch {`
`253`	`253`	`return undefined;`
`254`	`254`	`}`
`255`	`255`	`}`
`@@ -274,63 +274,63 @@ const untouchedReplace: (pattern: RegExp \| string, replacement: string) => strin`
`274`	`274`	`function extractSplit(instance: string) {`
`275`	`275`	`try {`
`276`	`276`	`return instance.split;`
`277`		`- } catch (err) {`
	`277`	`+ } catch {`
`278`	`278`	`return undefined;`
`279`	`279`	`}`
`280`	`280`	`}`
`281`	`281`	`function extractStartsWith(instance: string) {`
`282`	`282`	`try {`
`283`	`283`	`return instance.startsWith;`
`284`		`- } catch (err) {`
	`284`	`+ } catch {`
`285`	`285`	`return undefined;`
`286`	`286`	`}`
`287`	`287`	`}`
`288`	`288`	`function extractEndsWith(instance: string) {`
`289`	`289`	`try {`
`290`	`290`	`return instance.endsWith;`
`291`		`- } catch (err) {`
	`291`	`+ } catch {`
`292`	`292`	`return undefined;`
`293`	`293`	`}`
`294`	`294`	`}`
`295`	`295`	`function extractSubstring(instance: string) {`
`296`	`296`	`try {`
`297`	`297`	`return instance.substring;`
`298`		`- } catch (err) {`
	`298`	`+ } catch {`
`299`	`299`	`return undefined;`
`300`	`300`	`}`
`301`	`301`	`}`
`302`	`302`	`function extractToLowerCase(instance: string) {`
`303`	`303`	`try {`
`304`	`304`	`return instance.toLowerCase;`
`305`		`- } catch (err) {`
	`305`	`+ } catch {`
`306`	`306`	`return undefined;`
`307`	`307`	`}`
`308`	`308`	`}`
`309`	`309`	`function extractToUpperCase(instance: string) {`
`310`	`310`	`try {`
`311`	`311`	`return instance.toUpperCase;`
`312`		`- } catch (err) {`
	`312`	`+ } catch {`
`313`	`313`	`return undefined;`
`314`	`314`	`}`
`315`	`315`	`}`
`316`	`316`	`function extractPadStart(instance: string) {`
`317`	`317`	`try {`
`318`	`318`	`return instance.padStart;`
`319`		`- } catch (err) {`
	`319`	`+ } catch {`
`320`	`320`	`return undefined;`
`321`	`321`	`}`
`322`	`322`	`}`
`323`	`323`	`function extractCharCodeAt(instance: string) {`
`324`	`324`	`try {`
`325`	`325`	`return instance.charCodeAt;`
`326`		`- } catch (err) {`
	`326`	`+ } catch {`
`327`	`327`	`return undefined;`
`328`	`328`	`}`
`329`	`329`	`}`
`330`	`330`	`function extractReplace(instance: string) {`
`331`	`331`	`try {`
`332`	`332`	`return instance.replace;`
`333`		`- } catch (err) {`
	`333`	`+ } catch {`
`334`	`334`	`return undefined;`
`335`	`335`	`}`
`336`	`336`	`}`
`@@ -404,7 +404,7 @@ const untouchedNumberToString = Number.prototype.toString;`
`404`	`404`	`function extractNumberToString(instance: number) {`
`405`	`405`	`try {`
`406`	`406`	`return instance.toString;`
`407`		`- } catch (err) {`
	`407`	`+ } catch {`
`408`	`408`	`return undefined;`
`409`	`409`	`}`
`410`	`410`	`}`
Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ function stringifyInternal<Ts>(`
`157`	`157`	`// if user defined custom sync serialization function, we use it before next ones`
`158`	`158`	`try {`
`159`	`159`	`return value[toStringMethod]();`
`160`		`- } catch (err) {`
	`160`	`+ } catch {`
`161`	`161`	`// fallback to defaults...`
`162`	`162`	`}`
`163`	`163`	`}`
`@@ -212,7 +212,7 @@ function stringifyInternal<Ts>(`
`212`	`212`	`// Instance (or one of its parent prototypes) overrides the default toString of Object`
`213`	`213`	`return (value as any).toString(); // <-- Can throw`
`214`	`214`	`}`
`215`		`- } catch (err) {`
	`215`	`+ } catch {`
`216`	`216`	`// Only return what would have been the default toString on Object`
`217`	`217`	`return '[object Object]';`
`218`	`218`	`}`
Original file line number	Diff line number	Diff line change
@@ -788,7 +788,7 @@ describe(`NoRegression`, () => {
`788`	`788`	`try {`
`789`	`789`	`fc.modelRun(setup, cmds);`
`790`	`790`	`return true;`
`791`		`- } catch (err) {`
	`791`	`+ } catch {`
`792`	`792`	`return false;`
`793`	`793`	`}`
`794`	`794`	`},`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ const computeMaximalStackSize = () => {`
`12`	`12`	`};`
`13`	`13`	`try {`
`14`	`14`	`f();`
`15`		`- } catch (_err) {`
	`15`	`+ } catch {`
`16`	`16`	`// throws 'RangeError: Maximum call stack size exceeded'`
`17`	`17`	`}`
`18`	`18`	`return depth;`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ function dropAllFromObj(obj: unknown): (() => void)[] {`
`175`	`175`	`const descriptor = safeObjectGetOwnPropertyDescriptor(obj, k)!;`
`176`	`176`	`delete (obj as any)[k];`
`177`	`177`	`restores.push(() => safeObjectDefineProperty(obj, k, descriptor));`
`178`		`- } catch (err) {`
	`178`	`+ } catch {`
`179`	`179`	`// Object.prototype cannot be deleted, and others might too`
`180`	`180`	`}`
`181`	`181`	`}`
Original file line number	Diff line number	Diff line change
@@ -60,7 +60,7 @@ describe(`ReplayFailures (seed: ${seed})`, () => {
`60`	`60`	`expect(data).toEqual(out.counterexample![0]);`
`61`	`61`	`validCallIndex = numCalls;`
`62`	`62`	`++numValidCalls;`
`63`		`- } catch (err) {`
	`63`	`+ } catch {`
`64`	`64`	`// noop`
`65`	`65`	`}`
`66`	`66`	`++numCalls;`
Original file line number	Diff line number	Diff line change
@@ -30,7 +30,7 @@ describe(`ObjectArbitrary (seed: ${seed})`, () => {
`30`	`30`	`try {`
`31`	`31`	`JSON.parse(revJson(json));`
`32`	`32`	`return false;`
`33`		`- } catch (err) {`
	`33`	`+ } catch {`
`34`	`34`	`return true;`
`35`	`35`	`}`
`36`	`36`	`}),`