Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename for targetAmountX in CalcGreatestMatchingRatio, should just be reserveX #239

Open
PossibilityResult opened this issue Dec 11, 2022 · 1 comment
Open

Rename for targetAmountX in CalcGreatestMatchingRatio, should just be reserveX #239

PossibilityResult opened this issue Dec 11, 2022 · 1 comment
Assignees
@PossibilityResult
Labels
quality of life

Comments

@PossibilityResult
Copy link
Contributor

PossibilityResult commented Dec 11, 2022 •
edited
Loading

targetAmountX makes no sense since it has nothing to do with a target amount.

The ratio of targetAmount0 to targetAmount1 can be seen as a targetRatio but this doesn't make sense for amounts.
@PossibilityResult PossibilityResult changed the title proposing a rename for "targetAmountX" in "CalcGreatestMatchingRatio", should just be "reserveX" Rename for "targetAmountX" in "CalcGreatestMatchingRatio", should just be "reserveX" Dec 11, 2022
@PossibilityResult PossibilityResult changed the title Rename for "targetAmountX" in "CalcGreatestMatchingRatio", should just be "reserveX" Rename for targetAmountX in CalcGreatestMatchingRatio, should just be reserveX Dec 11, 2022
@PossibilityResult PossibilityResult self-assigned this Dec 11, 2022
@teddyknox
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PossibilityResult PossibilityResult

Labels
quality of life
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teddyknox @PossibilityResult