Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pattern Lab To "Actually" Ignore Certain Files / Folders #20

Open
sghoweri opened this issue Sep 27, 2017 · 0 comments
Open

Update Pattern Lab To "Actually" Ignore Certain Files / Folders #20

sghoweri opened this issue Sep 27, 2017 · 0 comments

Comments

@sghoweri
Copy link
Collaborator

sghoweri commented Sep 27, 2017

Short version: Pattern Lab's Pattern Data reclusively looks through every single file and directory in the _patterns folder, independent on what file types / directory names are flagged to be ignored.

Currently these ignore settings are used to omit what gets copied over to the public folder when building however as I found out firsthand, these critically aren't ignored when the files get globbed.

...This causes Pattern Lab to become COMPLETELY unusable if say, you are independently versioning your components in a monorepo via Lerna, and Pattern Lab discovers all these yummy files in the nested node_modules folders. Yes, crappy workflows involving never-ending symlinks or file copying can work, but those solutions aren't sustainable when PL is hard-wired to want your patterns to live in one and only one place.

We have a working solution that involves using Symphony Finder to exclude the paths we want PL to ignore which seems to be doing the trick. With a little refactoring to configure this to use the YAML config, this should be PR ready: https://github.com/bolt-design-system/bolt/blob/feature/v0.3.0-alpha.4/.patches/ignoreCertainFolders.patch

CC @EvanLovely @evanmwillhite @jesconstantine @aleksip @bradfrost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant