Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Unit Of Work Support For JDBI #14

Open
isopropylcyanide opened this issue May 5, 2020 · 6 comments
Open

Unit Of Work Support For JDBI #14

isopropylcyanide opened this issue May 5, 2020 · 6 comments

Comments

@isopropylcyanide
Copy link

I've published a package to Maven Central that I've developed to add Support for Unit of Work for a Dropwizard App that uses JDBI using a @JdbiUnitOfWork annotation

The project lives here: https://github.com/isopropylcyanide/dropwizard-jdbi-unitofwork
image

I'm interested in contributing upstream. Would really appreciate if someone can review the source and see if it's worth it.
It is being actively used in our production since the last quarter. I have also published a series of articles on the same

Part I
Part II

image

@joschi
Copy link
Member

joschi commented May 11, 2020

@isopropylcyanide Thanks for opening this issue and for your write-up!
Sorry it took a bit longer to respond.

I see that your project is aimed ad jDBI 2.x (via dropwizard-jdbi) and not Jdbi 3 (via dropwizard-jdbi3).

Since we split out the jDBI 2.x support in Dropwizard 2.0.0, it would make sense to create a pull request against https://github.com/dropwizard/dropwizard-jdbi/.

What do you think?

@isopropylcyanide
Copy link
Author

I agree. I'll raise it over there. Thank you.

@joschi joschi transferred this issue from dropwizard/dropwizard May 12, 2020
@joschi
Copy link
Member

joschi commented May 12, 2020

@isopropylcyanide I've transferred the issue to the other repository.

@isopropylcyanide
Copy link
Author

@joschi I think the issue was transferred here. Can we resurrect this thread?

Does it make sense if I work towards migrating this to JDBI v3. Do you see a value in this project?

@joschi
Copy link
Member

joschi commented Jan 21, 2021

Does it make sense if I work towards migrating this to JDBI v3. Do you see a value in this project?

There still seem to be some projects using jDBI 2.x with Dropwizard 2.x:

Maven Central statistics for dropwizard-jdbi

So merging https://github.com/isopropylcyanide/dropwizard-jdbi-unitofwork into this project would definitely not be wasted effort.

On a personal note, it would be great to get both, support for jDBI 2.x in this project and getting support for JDBI 3.x in https://github.com/dropwizard/dropwizard/.

Feel free to open a PR here for merging the upstream project and I'll be happy to review & merge. 😃

@isopropylcyanide
Copy link
Author

I'll work on both. Need to test changes for 3.x though. Thanks for the visualization on the usages of 2.0. Pretty cool.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants