Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Refactor(cli): refactor cli to get a better adaption with core 2.0.0 #70

Closed
sheepbox8646 opened this issue Jun 20, 2024 · 1 comment
Closed
Labels
bug Something isn't working enhancement New feature or request todo

Comments

@sheepbox8646
Copy link
Member

Description

Since the local mode was taken into effect, we had discovered some problem of ncli(@newcar/cli), and after 2.0, it runs with a wrong way, so it needs some fixes and refactor

Bugs you need to face

  • If you try to create a long video (under the common condition, it's greater that 200frames), it will throw a wired error.
  • Now it has a dangerous bug: no matter what js file you input, it always output a video that duration is 0, so it cannot be used now.

We need a person to refactor it.

If you are interested in it, please comment under this issue.

@sheepbox8646 sheepbox8646 added bug Something isn't working enhancement New feature or request todo labels Jun 20, 2024
@sheepbox8646 sheepbox8646 pinned this issue Jun 20, 2024
@0x002500
Copy link
Collaborator

I think the dangerous bug is easy to fix.You just need to add a token line at the top of the local mode JS file, and check the token line before outputting the video.

For example, the source file is:

// Initialization and import are omitted
const app = engine.createLocalApp(1600 /* width of the canvas */, 900 /* height of the canvas */)
// The rest is omitted, remember, there is no `play` method in local mode

but now there is:

@localMode
// Initialization and import are omitted
const app = engine.createLocalApp(1600 /* width of the canvas */, 900 /* height of the canvas */)
// The rest is omitted, remember, there is no `play` method in local mode

TIPS: This is only my idea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request todo
Projects
None yet
Development

No branches or pull requests

2 participants