Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New options #3

Open
jkampco opened this issue May 6, 2021 · 5 comments
Open

New options #3

jkampco opened this issue May 6, 2021 · 5 comments
Assignees

Comments

@jkampco
Copy link

jkampco commented May 6, 2021

Hey,

This is a great start. Can you try and have a functionality where the background of the tweet content itself is kept to white? When you try to pull in tweets with images, the background kind of merges with the images.

@drkPrince
Copy link
Owner

Hey, can you give some example where you are facing this issue.

Also, did you try other backgrounds?

I had plans to add white bg, but it didn't look so good. I will add glassmorphism though.

@jkampco
Copy link
Author

jkampco commented May 7, 2021

image

I am suggesting that you keep the area behind the tweet text to be white and bg be colorful

@drkPrince
Copy link
Owner

Yes, I understand you.

Actually the tweet bg is already white, but with reduced opacity. I think it has better aesthetics than #ffffff. If you have better design ideas, shoot a PR.

One way to prevent merging of tweet bg and tweet image is to try different backgrounds.

Or I could add some solid colors for background.

@jkampco
Copy link
Author

jkampco commented May 7, 2021

For now, we could try keeping a setting to change the opacity of the tweet bg to a user's liking. That will solve the issue. Solid bgs are good, but I feel the white tweet bg with a gradient / solid colorful bg will make the content stand out when people share the image.

@drkPrince
Copy link
Owner

Alright, I will try adding an opacity slider. 👍

@drkPrince drkPrince self-assigned this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants