-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch commands #255
Comments
Add PatchIndexRangeBatch concept to represent a batch or collection of PatchIndexRange objects. This also houses the parsing logic to constitute a PatchIndexRangeBatch from a string representation of the form "1 3-5 7 9 10-13". In the near future I plan to use this to implement batching into the request-review command so that I can get rid of the batch-request-review command and reduce the command surface area. This relates to issue #255. <!-- ps-id: 21328cb6-0e2a-49ed-8134-d0a205675f01 -->
Add batching support to the request-review command so that users would be able to request review for a series of patches and patch series with one go. This also makes it so the request-review command supports the same functionality as the batch-request-review command. Which will allow me to now remove the batch-request-review command and reduce the surface area of the commands so it isn't so overwhelming to new users. This relates to issue #255. [changelog] added: batching support to the request-review command <!-- ps-id: 524746ce-3a64-435d-8a7d-25149ad6be97 -->
Remove batch-request-review command because the request-review command now natively supports batching in a far more robust fashion. Therefore, the batch-request-review command is no longer needed and is just noise within the command surface area. Hence, why I am removing it to streamline the command surface area and make the app feel less overwhelming to newcomers. This relates to issue #255. [changelog] removed: batch-request-review command <!-- ps-id: 32bcc8f6-5d73-4c74-8b16-2f55f0047842 -->
The parsing for this has been implemented and it has been integrated into the The behavior I implemented for handling errors with batched commands in However, even though we have the parsing available to all of the commands. I think that the behavior we want for other commands may be different. For example if we talk about So my point is that we likely just need to think through each of the cases where we want batching support and determine what type of behavior we want for that command when batching. |
Now that we have a proper syntax for patch series
1-3
, we can think about adding multiple arguments to certain commands in an unambiguous way from a parsing standpoint. The idea is that agps command
followed by multiple rather than a single series:gps command 1 2-3 4-7
should batch said commands to something likegps command 1; gps command 2-3; gps command 4-7
.This will subsume commands like
gps batch-request-review
.Now there are some questions that we need to answer in order to fully develop this idea.
The text was updated successfully, but these errors were encountered: