Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dremio__make_temp_relation doesn't get default value #123

Open
ArgusLi opened this issue Feb 8, 2023 · 1 comment
Open

dremio__make_temp_relation doesn't get default value #123

ArgusLi opened this issue Feb 8, 2023 · 1 comment
Assignees
@ArgusLi
Labels
bug Something isn't working

Comments

@ArgusLi
Copy link
Contributor

ArgusLi commented Feb 8, 2023

The temp relation gets the same name as the target relation, because suffix in dremio__make_temp_relation does not get a default value like it does in dbt-core.
@ArgusLi ArgusLi added the bug Something isn't working label Feb 8, 2023
@ArgusLi ArgusLi mentioned this issue Feb 8, 2023
Closed
@ArgusLi ArgusLi self-assigned this Feb 15, 2023
@ArgusLi
Copy link
Contributor Author

ArgusLi commented Feb 26, 2023

@Marnixvdb taking a closer look at the suffix, it actually appears that the default value is generated before dremio__make_temp_relation. My understanding is that the macro make_temp_relation in dbt-core is called first, which has a default suffix of "__dbt_tmp". It then passes this default suffix to dremio__make_temp_relation to create the dremio temp relation. Is there something I'm missing here?

On another note, I wonder why dremio__make_temp_relation deletes the temp relation? @fabrice-etanchaud would you happen to know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArgusLi ArgusLi

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ArgusLi