Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolution Chain Support #2

Open
drazenbebic opened this issue Jun 2, 2022 · 2 comments
Open

Evolution Chain Support #2

drazenbebic opened this issue Jun 2, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@drazenbebic
Copy link
Owner

When the --evolutions flat is set, the bot must output all evolutions of given Pokemon (if any).

If the given Pokemon was Pikachu, for example, the Evolution part of the message should look like this:

-- Evolutions --
Pichu > Pikachu > Raichu

The name of the pokemon which was queried should be bold. If, for example, Raichu was queried then it would look like:

-- Evolutions --
Pichu > Pikachu > Raichu

If the queried Pokemon has no evolutions, then the following message must appear:

-- Evolutions --
Articuno does not have any evolutions.

@drazenbebic drazenbebic added the enhancement New feature or request label Jun 2, 2022
@Zircadraeya
Copy link
Collaborator

Zircadraeya commented Jun 2, 2022

We can call the API for the specified Pokémon and from that obtain species.url. Calling that gives the evolution_chain.url which provides a json with the necessary info. It appears to all be in English so we'd then need to make calls to get the requested language names

It seems a bit long winded, but I don't see a more efficient option when we have a Pokémon name as the starting point

@drazenbebic
Copy link
Owner Author

@Zircadraeya We should do that nonetheless.

Keep in mind that we also want to implement a caching system, which would then retrieve these pokemon only once from the API, and then store them in the cache. Resulting in fewer requests and faster responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants