Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External link in menu menu open() error #4

Open
Sebbo94BY opened this issue Dec 21, 2014 · 0 comments
Open

External link in menu menu open() error #4

Sebbo94BY opened this issue Dec 21, 2014 · 0 comments

Comments

@Sebbo94BY
Copy link

If I enter an external link with target="_blank", the website tries to open() a page, which does not exist. Regarding to this, the website will show a 404 error, but the new tab is showing the correct website content.

To solve this issue I have removed the following line in your js/main-menu.js:

    else window.location = $item.find('a').attr('href');

My JS knowledge is not good enough to understand this line. I hope, you can fix this as fast as possible.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant