Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-folder query hides entries with folder #235

Open
fabian-thomas opened this issue Jan 26, 2025 · 0 comments
Open

Non-folder query hides entries with folder #235

fabian-thomas opened this issue Jan 26, 2025 · 0 comments

Comments

@fabian-thomas
Copy link

I found that when I query for an entry and one of the potential entries has a folder, another has none, then the entries with folder are hidden.

For example create two entries for https://github.com, one with and one without folder and then query: rbw get --full --raw https://github.com. This gives the non-folder one and not both.

I use this easy fix:

diff --git a/src/bin/rbw/commands.rs b/src/bin/rbw/commands.rs
index 8433e66..39e12bc 100644
--- a/src/bin/rbw/commands.rs
+++ b/src/bin/rbw/commands.rs
@@ -580,7 +580,7 @@ impl DecryptedCipher {
                 } else {
                     return false;
                 }
-            } else if self.folder.is_some() {
+            } else {
                 return false;
             }
         }

Feel free to add it to the codebase. The rationale is that there is no reason to assume that we have no match when an entry has a folder set but we did not even query for folders. This might break folders queries though, not sure about the interplay there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant