Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when tried to sync and login #218

Open
latipun7 opened this issue Nov 30, 2024 · 12 comments
Open

Error when tried to sync and login #218

latipun7 opened this issue Nov 30, 2024 · 12 comments

Comments

@latipun7
Copy link

rbw version 1.21.1

I tried to sync rbw with rbw sync but unsuccessful, got an error like in this issue #32. Then I tried to purge and relogin, but got an error when login.

❯ rbw login
rbw login: failed to log in to bitwarden instance: api request returned error: 429

Please help. Thank you.

@omentic
Copy link

omentic commented Nov 30, 2024

I am also getting this error. I switched to Bitwarden recently and only installed rbw yesterday, so thought I was just holding it wrong... rbw register seems to succeed, but rbw login fails.

@tmeijn
Copy link

tmeijn commented Dec 1, 2024

Getting the same error: needed to re-install laptop so need to login again using rbw. Seems like something has been broken by a Bitwarden change.

I tried to generate debug logs like here, but could not get it to work and there is no developer documentation that I could find.

rbw register indeed does seem to work, although it does not give any output at all, just a zero exit code.

@pcrockett
Copy link

Not sure if it's related, but I'm also seeing this in ~/.loca/share/rbw/agent.err after running rbw unlock:

** (pinentry-gtk:14554): WARNING **: 20:11:14.144: it took 104 tries to grab the keyboard
�[90m[�[0m2024-12-02T19:11:25Z �[33mWARN �[0m rbw::api�[90m]�[0m failed to parse JSON: 

I find the "failed to parse JSON" part there interesting. No idea if it's relevant. Sadly, the error message stops right there.

@pcrockett
Copy link

Looks like this might fix it: #219

@tmeijn
Copy link

tmeijn commented Dec 3, 2024

Can confirm that for me the build of that PR solves the issue! 🚀

@davla
Copy link

davla commented Dec 3, 2024

I tried again just now with the build from #219 and it no longer seems to work. Can anyone else confirm?

@furstblumier
Copy link

Facing the same issue with the current build from main. Neither login nor register works

@Anachron
Copy link

Anachron commented Dec 6, 2024

Whenever I try to login it tells me Invalid username or password.

However the latest beta client on Android does let me login with these exact credentials.

I use a selfhosted vaultwarden instance.

@apprehensions
Copy link

A 1.12.1 build with the PR patched fixes this issue for me.

@davla
Copy link

davla commented Dec 11, 2024

I tried again just now with the build from #219 and it no longer seems to work. Can anyone else confirm?

It turns out that the PR build does indeed work. I just forgot to set RBW_AGENT to the locally built binary.

@ymatsiuk
Copy link

Would be great if it was possible to set headers outside of the code. Imagine there was a variable BW_API_HEADERS (could be a configuration entry) that would allow us to set arbitrary headers in key0=value0,key1=value1 format. In this case we don't have to change the code every time BW introduces a change or a mandatory header. The code would look much simpler just iterating over a comma separated list and appending those as headers 🤔

@adrianschlatter
Copy link

adrianschlatter commented Dec 13, 2024

Yup, I also ran into this problem. rbw register seems to work, rbw login fails with 429. I installed the official bw client on the same machine => no 429 problem. @davla: I'd offer to test #219, too, but I run into a problem. I'm a newby regarding rust/cargo so maybe I'm just doing an obvious mistake that you could help me correct? 🙏

git clone [email protected]:doy/rbw.git
cd rbw
git fetch origin pull/219/head:pr219
git checkout pr219
cargo install --locked -Znext-lockfile-bump --path .

I get

» cargo install --locked -Znext-lockfile-bump --path rbw
  Installing rbw v1.12.1 (/home/adrian/projects/rbw)
    Updating crates.io index
   Compiling futures-core v0.3.31
   Compiling futures-sink v0.3.31
.
.
.
   Compiling axum v0.7.5
   Compiling rbw v1.12.1 (/home/adrian/projects/rbw)
error[E0658]: use of unstable library feature 'result_option_inspect'
    --> src/bin/rbw/commands.rs:1646:31
     |
1646 |     crate::actions::version().inspect_err(|_e| {
     |                               ^^^^^^^^^^^
     |
     = note: see issue #91345 <https://github.com/rust-lang/rust/issues/91345> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `rbw` (bin "rbw") due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `rbw v1.12.1 (/home/adrian/projects/rbw)`, intermediate artifacts can be found at `/home/adrian/projects/rbw/target`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

I can compile the main branch, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants