You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've identified two issues with the current get by uri implementation:
Ip addresses can't be matched in domain mode. For example try rbw get https://192.168.178.1 with an entry that has the uri https://192.168.178.1 configured. This is because the domain_port invocation here does not return anything because the entry has no domain. I'm not sure how this can be fixed. One option would be to use domain or ip address there.
If exact mode is used, entries without the trailing slash configured in bitwarden are not matched. This is because url.to_stringhere returns the url with trailing slash even when rbw get https://example.com (no trailing slash) is used for querying. Again, I'm not sure how to fix this. In exact mode you could argue that it should actually exactly match, but then you would need to add both entries https://example.com/ and https://example.com to your bitwarden entry so that all clients handle it correctly. Therefore I think it would be best to make this a special case that even matches in exact mode. For reference: firefox with the bitwarden android app only match when https://example.com is configured, but not when https://example.com/ is configured.
I've identified two issues with the current get by uri implementation:
rbw get https://192.168.178.1
with an entry that has the urihttps://192.168.178.1
configured. This is because thedomain_port
invocation here does not return anything because the entry has no domain. I'm not sure how this can be fixed. One option would be to use domain or ip address there.url.to_string
here returns the url with trailingslash
even whenrbw get https://example.com
(no trailing slash) is used for querying. Again, I'm not sure how to fix this. In exact mode you could argue that it should actually exactly match, but then you would need to add both entrieshttps://example.com/
andhttps://example.com
to your bitwarden entry so that all clients handle it correctly. Therefore I think it would be best to make this a special case that even matches in exact mode. For reference: firefox with the bitwarden android app only match whenhttps://example.com
is configured, but not whenhttps://example.com/
is configured.I personally fix 2. with this patch:
The text was updated successfully, but these errors were encountered: