Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better default value for Binary Mode #304

Open
vladiulianbogdan opened this issue Sep 10, 2024 · 1 comment
Open

Better default value for Binary Mode #304

vladiulianbogdan opened this issue Sep 10, 2024 · 1 comment

Comments

@vladiulianbogdan
Copy link

I have a question regarding the Binary Mode. Could we set some better default values for binary? For example, application/pdf will just not work by default. The user has to set by itself the BINARY_CONTENT_TYPES env variable.

If you agree that we could set some better defaults, I can come with a PR for this.

@dougmoscrop
Copy link
Owner

Yes that makes sense to me. What do you think about going the inverse and having a list of known text types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants