You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version: checked on 4.x (but probably applicable to 3.x too)
Steps to reproduce:
eval someobject.crashTest = Verb("crashme");
Ctrl-P and edit the newly created verb
Break the function code (i.e. either empty the whole file, or just garble the function declaration to be incorrect, etc.)
Save and close editor
Ctrl-P and try to open the verb
Observed behavior:
Game engine crashes and terminates:
SyntaxError: Unexpected token )
at Deserializer.deserialize (...room.js-server\src\lib\deserializer.js...)
at Handler.get (D:\dev\room.js-server\src\lib\world-object-proxy-builder.js...)
at ProgrammerController.onGetVerb (...room.js-server\src\controllers\programmer-controller.js...)
at SocketController.onGetVerb (...room.js-server\src\controllers\socket-controller.js...)
Only workaround is to fix the offending file on-disk before relaunching the game engine.
There ought to be some robustness checks:
so that programmers can't that easily crash the engine due to programming mistakes.
Additionally, to also prevent mis-behaving clients from crashing the engine (e.g. not sending the expected JSON payload, due to bugs etc. Err... that's initially how I stumbled on that issue ^^)
The text was updated successfully, but these errors were encountered:
Version: checked on 4.x (but probably applicable to 3.x too)
Steps to reproduce:
Observed behavior:
Game engine crashes and terminates:
Only workaround is to fix the offending file on-disk before relaunching the game engine.
There ought to be some robustness checks:
The text was updated successfully, but these errors were encountered: