Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
GPX::GPXFile.new
requires an instance of theFile
class for thegpx_file
option when specifying a file, but I think this should be a bit more flexible.For instance, Issue #34 expects
StringIO
andTempfile
to be loaded, and I agree.I have checked the source of
Nokogiri::XML::Document.parse
for this modification. As a result, I thought it would be better if the parameters ofGPX::GPXFile.new
were the same as the API ofNokogiri::XML::Document.parse
, but for compatibility reasons, I concluded that the implementation as shown in this PR would be better.Incidentally, the idea of
respond_to?(:read)
is exactly whatNokogiri::XML::Document.parse
does.Implementing this PR facilitates the following scenarios:
I especially wanted to use it in the pipeline from STDIN, as in the first example.