-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessiblity] Narrator cannot announce items correctly when switching the items by using up/down keyboard arrow that without expand the dropdown list panel #12421
Comments
@LeafShi1 - we can't backport the fix for the drop down closing only on ENTER until this issue is fixed as well. |
The root cause is here winforms/src/System.Windows.Forms/src/System/Windows/Forms/Controls/TextBox/TextBoxBase.cs Line 1740 in ef16383
but for the issue Narrator announced the FlatStyle/BoserStyle property item twice, I don't think this is a real bug.
The problem is obvious from the announce of the If we want to solve this problem, we can only make the item selected without selecting it in the edit text box, the result is like below For issue the first time unread in its entirety, it should be fixed in PR #12431, once the edit text box gets the focus, the value can be read out completely. @Tanya-Solyanik What do you think about this issue? |
@LeafShi1 - I added some comments in the PR. |
…r experience in dropdown type editors in property grid (#12605) Backport of #12508, #12431, #12356 and #12479 to release/9.0 Fixes #12607 NET10 Bugs: #12434, #12421, #12440, #12031 Bug Description There are four issues that occur when using the up/down keys to switch property values in the property page. When navigating to "Auto Size" dropdown using the up/down arrow keys, it is getting auto selected without hitting ENTER After using Tab to switch property values, then using the up/down keys to switch items in the drop-down box expanded by F4 will cause the drop-down box to collapse directly [Accessibility] When using up/down to toggle property value on edit text box, The Accessibility rectangle focuses on the entire property row instead of the original edit text box [Accessibility] Narrator cannot announce items correctly when switching the items by using up/down keyboard arrow that without expand the dropdown list panel Customer Impact PropertyGrid drop down type editor does not support conventional keyboard navigation. Usually, selection is committed when the ENTER key is pressed. However, in this case value is committed on the Down arrow press. Then the drop down list is expanded, the screen reader user might want to navigate through all values in the drop down using the arrows, on each arrow key press the new item should be presented (and announced) in the selection text box, however, the drop down is closed on the first arrow key. According to the accessibility SMEs, this is a major problem - the keyboard users are losing their work by committing a wrong value. Screen reader user don't get correct feedback when navigating through the drop down list.
.NET version
.NET SDK 10.0.100-alpha.1.24553.3
Did it work in .NET Framework?
No
Did it work in any of the earlier releases of .NET Core or .NET 5+?
No, this issue cannot repro in .NET 3.1, can repro in .NET 5.0.
.NET 3.1:
![Image](https://private-user-images.githubusercontent.com/94418985/382667701-3cd87bea-659a-445b-b475-8468be30fe5b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjg1NDYsIm5iZiI6MTczOTcyODI0NiwicGF0aCI6Ii85NDQxODk4NS8zODI2Njc3MDEtM2NkODdiZWEtNjU5YS00NDViLWI0NzUtODQ2OGJlMzBmZTViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE3NTA0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWExZTMxMjlhYmUxMzYzYTcyYWZjYTI1N2UwNzhmMWFjYjdmOTZmOWExNGQ2MGZjYTZkNTczOTI2OTEwY2RlM2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.x6FDULr5_iHERdR7r-4oSpgsVZdcQ1uKR2BQzBo1Tnc)
Issue description
When switching the items by using up/down keyboard arrow that without expand the dropdown list panel, Narrator announced the FlatStyle/BoserStyle property item twice, the first time unread in its entirety.
![Image](https://private-user-images.githubusercontent.com/94418985/382667893-2c860186-92be-4cac-a191-6959995cedbd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjg1NDYsIm5iZiI6MTczOTcyODI0NiwicGF0aCI6Ii85NDQxODk4NS8zODI2Njc4OTMtMmM4NjAxODYtOTJiZS00Y2FjLWExOTEtNjk1OTk5NWNlZGJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE3NTA0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3ZTQ5ZjQzY2RmMWZhOWIxY2NlMGJkYjY4NGRiNjg4NGExZjU3MGE0NzY3MjI5ZWViZWZlOTE5Njg0NzJkOGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.uWrNewqzOwerW4my3T-PjABvuK0R9lhtxQaozOmBb74)
narrtor.mp4
Expected behavior:
![Image](https://private-user-images.githubusercontent.com/94418985/382660111-3f29b2b9-88c0-4a73-9268-48dde318729e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjg1NDYsIm5iZiI6MTczOTcyODI0NiwicGF0aCI6Ii85NDQxODk4NS8zODI2NjAxMTEtM2YyOWIyYjktODhjMC00YTczLTkyNjgtNDhkZGUzMTg3MjllLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE3NTA0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgyNjEyYzUyNWU3Nzg4NmYxNjAyM2QxYTZiOTQ1YjQ2ZWEwNjJiMzRlNzJjM2U0NDgxZDYxM2U2MDJhZDNmN2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.J4g5dkWV3NF-91B1M7lG_umSoMuF-v9rf7amuRg9iL4)
Compare with NVDA tool, Narrator should be read the FlatStyle/BoserStyle property item only once and in its entirety.
nvda.mp4
Steps to reproduce
More info:
The text was updated successfully, but these errors were encountered: