Add UIA_AutomationFocusChangedEventId to SelectInternal of the TextBoxBase.cs #12479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropertyGridView.GridViewTextBox
|
There have extra "item selected" is announced for BackColor/ForeColor/Cursor property with Narrator when using commit1 
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12479 +/- ##
===================================================
+ Coverage 75.73242% 75.73942% +0.00699%
===================================================
Files 3153 3157 +4
Lines 635807 636106 +299
Branches 46975 47004 +29
===================================================
+ Hits 481512 481783 +271
+ Misses 150870 150866 -4
- Partials 3425 3457 +32
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
added
the
waiting-review
…ngle refocus the current text box
src/System.Windows.Forms/src/System/Windows/Forms/Controls/TextBox/TextBoxBase.cs
Outdated
Show resolved
Hide resolved
LeafShi1
changed the title
Tanya-Solyanik
added
waiting-for-testing
LeafShi1
added
waiting-review
Tanya-Solyanik
approved these changes
Dec 9, 2024
dotnet-policy-service
bot
removed
the
waiting-review
LeafShi1
added a commit
to LeafShi1/winforms
that referenced
this pull request
Dec 9, 2024
…xBase.cs (dotnet#12479) * Add UIA_AutomationFocusChangedEventId in SelectInternal function of PropertyGridView.GridViewTextBox * Add a check that when the selected text is (0, 0), let the AI rectangle refocus the current text box * Rename the variables of function SelectInternal
Tanya-Solyanik
pushed a commit
that referenced
this pull request
Jan 9, 2025
…r experience in dropdown type editors in property grid (#12605) Backport of #12508, #12431, #12356 and #12479 to release/9.0 Fixes #12607 NET10 Bugs: #12434, #12421, #12440, #12031 Bug Description There are four issues that occur when using the up/down keys to switch property values in the property page. When navigating to "Auto Size" dropdown using the up/down arrow keys, it is getting auto selected without hitting ENTER After using Tab to switch property values, then using the up/down keys to switch items in the drop-down box expanded by F4 will cause the drop-down box to collapse directly [Accessibility] When using up/down to toggle property value on edit text box, The Accessibility rectangle focuses on the entire property row instead of the original edit text box [Accessibility] Narrator cannot announce items correctly when switching the items by using up/down keyboard arrow that without expand the dropdown list panel Customer Impact PropertyGrid drop down type editor does not support conventional keyboard navigation. Usually, selection is committed when the ENTER key is pressed. However, in this case value is committed on the Down arrow press. Then the drop down list is expanded, the screen reader user might want to navigate through all values in the drop down using the arrows, on each arrow key press the new item should be presented (and announced) in the selection text box, however, the drop down is closed on the first arrow key. According to the accessibility SMEs, this is a major problem - the keyboard users are losing their work by committing a wrong value. Screen reader user don't get correct feedback when navigating through the drop down list.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12421
Root Cause:
The highlighted part cannot be read completely because when using the up and down keys to switch options, the AI rectangle does not refocus the current edit text box, but directly switches from the rectangle of the previous option to the current rectangle size, as shown in the figure below
So the idea of repairing it is to focus the AI rectangle to the position (0, 0) first when executing CommitValue, and then focus on the new value
Proposed changes
SelectInternalof theTextBoxBasethat when the selected text is (0, 0), let the AI rectangle refocus the current text boxCustomer Impact
Regression?
Risk
Screenshots
Before
When switching the items by using up/down keyboard arrow that without expand the dropdown list panel, Narrator can not announced the property item entirety.
After
When switching the items by using up/down keyboard arrow that without expand the dropdown list panel, Narrator announced the property item entirety.
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow