Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add System.Text.Json and System.Reflection.Metadata to Version Details #964

Open
mthalman opened this issue Feb 24, 2023 · 2 comments
Open

Add System.Text.Json and System.Reflection.Metadata to Version Details #964

mthalman opened this issue Feb 24, 2023 · 2 comments

Comments

@mthalman
Copy link
Member

Dependency flow needs to be enabled for System.Text.Json and System.Reflection.Metadata in order to prevent prebuilts from occurring in source-build for this repo.

Related to dotnet/installer#15437
This was referenced Feb 24, 2023
Merged
Closed
@mmitche
Copy link
Member

mmitche commented Feb 27, 2023

@mthalman I think this change works, but SBRPs for the two deps are the right way to go. They don't appear in the output packages, and depending on previously source built packages here seems like the wrong thing to do.

@dazinator
Copy link

I'd love to know why i just got a github notification about this random issue but I can't work it out.. I am not subscribed or watching.. no one has mentioned me.. it remains an enigma ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dazinator @mmitche @mthalman