Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding vulnerability detection to PR checks in SBRP #4577

Open
ellahathaway opened this issue Aug 23, 2024 · 3 comments
Open

Consider adding vulnerability detection to PR checks in SBRP #4577

ellahathaway opened this issue Aug 23, 2024 · 3 comments
Labels
area-sbrp Source build reference packages

Comments

@ellahathaway
Copy link
Member

In this PR comment, it was highlighted that we might accidentally introduce (or re-introduce) vulnerable packages into SBRP without being aware of potential vulnerabilities until we check for them internally.

Given the complexity of removing certain packages in SBRP (adding a new package, waiting for rebootstrap, removing the old package, updating self-reference), it's crucial to avoid adding vulnerable packages whenever possible. Implementing a validation check in PRs to detect vulnerable packages would be beneficial. We need a solution that is easy to use and does not require submitting reports to an internal system. According to this blog post, the dotnet CLI can detect vulnerabilities using the command dotnet list package --vulnerable in projects, so we might be able to leverage that.

The other thing to consider is whether we'd want to detect already-checked-in packages for vulnerabilities, or if we'd rather only check packages being introduced in the PR.

@ellahathaway
Copy link
Member Author

@ellahathaway
Copy link
Member Author

See also dotnet/arcade#15019

ViktorHofer added a commit to dotnet/source-build-reference-packages that referenced this issue Aug 26, 2024
@MichaelSimons MichaelSimons added area-prebuilts Reducing the number of prebuilt packages in the tarball area-sbrp Source build reference packages and removed area-prebuilt-reduction area-prebuilts Reducing the number of prebuilt packages in the tarball untriaged labels Sep 5, 2024
@mthalman
Copy link
Member

mthalman commented Sep 5, 2024

Related to #3559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-sbrp Source build reference packages
Projects
Status: 10.0
Development

Successfully merging a pull request may close this issue.

3 participants