Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CA1515 throughout project causes CA0062 in partial classes #7512

Open
vsfeedback opened this issue Dec 18, 2024 · 1 comment
Open

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.


When using the automatic fixing of CA1515 (type can be made internal) and applying this fix to all occurrences in project or solution, it will cause CA0262 (conflicting accessibility modifiers) for partial classes defined in separate code files. Only one of the classe declarations is updated to internal, the other remains public.

To reproduce create multiple partial classes in an asp.net project derived from ControllerBase, each separated into a main class file and a related class file, then fix CA1515 throughout the project. (example: a TestController.cs and a TestController.Action.cs file containing a 'public partial class TestController : ControllerBase')


Original Comments

Feedback Bot on 12/10/2024, 10:55 PM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Feedback Bot on 12/11/2024, 05:46 PM:

Thank you for sharing your feedback! Our teams prioritize action on product issues with broad customer impact. See details at: https://docs.microsoft.com/en-us/visualstudio/ide/report-a-problem#faq. In case you need answers to common questions or need assisted support, be sure to use https://visualstudio.microsoft.com/vs/support/. We’ll keep you posted on any updates to this feedback.

Lijuan Ma [MSFT] on 12/12/2024, 01:15 AM:

Thank you for your feedback! Unfortunately, we cannot reproduce the issue on the latest version of enterprise-2022 VS product. If this is still an issue for you, please update to the latest version of VS. If you are still able to repro it, could you provide a simple repro project? Thank you for helping us build a better Visual Studio!

Why do we ask for more info?
We try to reproduce all issues reported with the information provided in the description and comments. When we can’t reproduce the issue, we ask you for more information so we can resolve the issue as quickly and efficiently as possible.
In our guidelines, you can get tips on how to provide clear and simple reproducible steps.

Andreas Saurwein on 12/12/2024, 02:20 AM:

CA1515.zip

Sample solution is attached. Its a standard asp.net app created by VS, only difference is splitting the WeatherForecastController class into two separate files and making it partial. I have added a comment to the WeatherForecastController.cs file at the location where the issue happens.

Andreas Saurwein on 12/12/2024, 01:19 AM:

Yes, this is still an issue in the latest VS 2022 Version 17.13.0 Preview 2.0
I will try to set up a sample solution, as clearly I can not share company code.

Feedback Bot on 12/12/2024, 06:45 PM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Feedback Bot on 12/12/2024, 10:36 PM:

This issue is currently being investigated. Our team will get back to you if either more information is needed, a workaround is available, or the issue is resolved.

@Hefaistos68
Copy link

Watching this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants