Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA1515 should not be reported for classes containing BDN benchmarks #7499

Open
drieseng opened this issue Dec 6, 2024 · 0 comments
Open

CA1515 should not be reported for classes containing BDN benchmarks #7499

drieseng opened this issue Dec 6, 2024 · 0 comments
Labels
Area-Microsoft.CodeAnalysis.NetAnalyzers Bug The product is not behaving according to its current intended design False_Positive A diagnostic is reported for non-problematic case

Comments

@drieseng
Copy link

drieseng commented Dec 6, 2024

Analyzer

Diagnostic ID: CA1515

Describe the improvement

CA1515 is currently reported for classes that contain BDN benchmark methods, but these classes actually have to be public.

Describe suggestions on how to achieve the rule

Please do not report this diagnostic for a class if one of the public methods of this class is annotated with ä BenchmarkDotNet.Attributes.BenchmarkAttribute custom attribute.
@Youssef1313 Youssef1313 added False_Positive A diagnostic is reported for non-problematic case Bug The product is not behaving according to its current intended design Area-Microsoft.CodeAnalysis.NetAnalyzers labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Microsoft.CodeAnalysis.NetAnalyzers Bug The product is not behaving according to its current intended design False_Positive A diagnostic is reported for non-problematic case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drieseng @Youssef1313