ResourceEditor should not serialize MemoryStreams using BinaryFormatter

[ericstj]

Visual Studio Version:
16.3.0 Preview 2.0

Summary:
See the scenario here: https://github.com/dotnet/coreclr/issues/26472#issuecomment-528112760

Steps to Reproduce:

1. Add a sound file to resource collection using the resources editor.

2. Select Embedded in .resx for the Persistence option.

Expected Behavior:
Sound file is embedded as a "stream" primitive in the resources. When read at runtime caller will get a stream over top of the embedded resource's bytes.

Actual Behavior:
Resource editor is writing a binary formatted MemoryStream. MemoryStream is not serializable on all frameworks, so this leads to an exception when trying to deserialize the MemoryStream on .NETCore.

User Impact:
User cannot store a sounds embedded in ResX on .NETCore.

[ericstj]

/cc @rainersigwald

[davkean]

If not a memory stream, then what? What is a "stream" primitive?

[ericstj]

When you call ResourceWriter with AddResource(string,Stream) or AddResource(string,Stream as object) it gets stored as the backing byte-array of the stream, then deserialized at runtime as an unmanagedmemorystream over the raw bytes in the dll mapped in memory.

@rainersigwald does ResGen have any paths where it will new up a stream for MemoryStream for something embedded in the resx? I thought we did, but looking now I don't see anything for the embedded one:
https://github.com/microsoft/msbuild/blob/3885a205f40944174a3e14396547f13db1196b82/src/Tasks/ResourceHandling/MSBuildResXReader.cs#L164-L199

Even if we did, we'd need ResXResourceWriter to also write in that different format, since anything written as binaryFormatted memory stream will not deserialize on core. So I'm guessing to fix this we'd need it to be written as application/x-microsoft.net.object.bytearray.base64 of MemoryStream type, then ResGen would need to special case MemoryStream and activate it before calling AddResource.