Merge pull request #9620 from drewnoakes/fix-collection-modified-exception

Fix "collection modified" exception

Author: drewnoakes

src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/UI/InfoBars/VsInfoBarService.cs

@@ -47,7 +47,10 @@ public VsInfoBarService(
         {
             lock (s_entries)
             {
-                foreach (InfoBar entry in s_entries)
+                // Copy the list to avoid "collection modified during enumeration" exceptions,
+                // as when the last project associated with an info bar is closed, we will
+                // remove that entry from the list.
+                foreach (InfoBar entry in s_entries.ToList())
                 {
                     entry.OnProjectClosed(_project);
                 }