Rationalize Microsoft.Build.Framework string resources and add ThrowIf* polyfills for exceptions by DustinCampbell · Pull Request #13276 · dotnet/msbuild

DustinCampbell · 2026-02-20T23:59:17Z

Summary

Modernize the string resources in Microsoft.Build.Framework and bring them in line with other dotnet repos. (01d840a)
Add various Microsoft.Build.Framework.resources.dlls to the Localization package, VSSetup and VSSetup.Arm64. (16c3145 and b89d070)
Add polyfills on non-.NET for ThrowIf* static methods on various exception types. (4b362f9)
Update AbsolutePath to use ArgumentNullException.ThrowIfNull(...) and ArgumentException.ThrowIfNullOrEmpty(...). (c0f748b)

Eventually, I intend to use the ThrowIf* polyfills throughout the MSBuild code base, which will allow several functions to be removed from ErrorUtilities. However, while wholly mechanical, that change will be pretty large, and I didn't want to pollute this pull request with all of that.

Copilot

Pull request overview

This pull request modernizes the string resource management in Microsoft.Build.Framework to align with patterns used in other .NET repositories. It migrates from a custom FrameworkResources class with Strings.resx to an auto-generated SR class with SR.resx, adds localized resource DLLs to packaging configurations, and introduces polyfills for exception helper methods (ThrowIf*) that are available in modern .NET but not in .NET Framework.

Changes:

Replaced custom FrameworkResources.GetString() pattern with auto-generated SR class using MSBuild's GenerateResxSource feature
Added Microsoft.Build.Framework.resources.dll files for all 13 supported locales to VSSetup, VSSetup.Arm64, and Localization packages
Introduced polyfill extension methods for ArgumentNullException, ArgumentException, ArgumentOutOfRangeException, and ObjectDisposedException with ThrowIf* helpers for non-.NET targets

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/Package/MSBuild.VSSetup/files.swr	Added Framework resource DLLs for x86 and x64 builds across all 13 locales
src/Package/MSBuild.VSSetup.Arm64/files.arm64.swr	Added Framework resource DLLs for ARM64 builds across all 13 locales
src/Package/Localization/Microsoft.Build.Localization.nuspec	Added Framework resource DLLs to NuGet package for all 13 locales
src/MSBuildTaskHost/MSBuildTaskHost.csproj	Changed wildcard polyfill inclusion to explicit file list to exclude ArgumentExceptionExtensions
src/Framework/Resources/xlf/.xlf (deleted Strings.)	Removed old Strings.xlf localization files
src/Framework/Resources/xlf/.xlf (added SR.)	Added new SR.xlf localization files with additional resource strings for polyfills
src/Framework/Resources/SR.resx	Replaced Strings.resx with SR.resx containing new and existing resource strings
src/Framework/Resources/AssemblyResources.cs	Deleted custom FrameworkResources class in favor of auto-generated SR
src/Framework/Polyfills/ArgumentExceptionExtensions.cs	Added polyfill extension methods using experimental C# extension syntax
src/Framework/PathHelpers/AbsolutePath.cs	Updated to use ArgumentException.ThrowIfNullOrEmpty and SR.PathMustBeRooted
src/Framework/Microsoft.Build.Framework.csproj	Enabled GenerateResxSource for SR.resx and added using directive for Resources namespace
src/Framework.UnitTests/AbsolutePath_Tests.cs	Split test methods and updated assertions for new exception messages

src/Framework/Polyfills/ArgumentExceptionExtensions.cs

src/Framework.UnitTests/AbsolutePath_Tests.cs

- Rename Strings.resx and Strings.*.xlf files to SR.resx and SR.*.xlf - Set <GenerateResxSource> property to true - Set <GenerateResxSourceEmitFormatMethods> property to true - Update <EmbeddedResource> to set <GenerateSource> to true - Add <Using Include="$(RootNamespace).Resources"/> to make it easier to access "SR" throughout Microsoft.Build.Framework - Change calls to FrameworkResources.GetString(...) to access the generated SR class. - Remove FrameworkResources (AssemblyResources.cs)

Add the following static extension methods to polyfill ThrowIf* static methods on non-.NET: - ArgumentNullException.ThrowIfNull(object?, string?) - ArgumentNullException.ThrowIfNull(void*, string?) - ArgumentException.ThrowIfNullOrEmpty(string?, string?) - ArgumentException.ThrowIfNullOrWhiteSpace(string?, string?) - ArgumentOutOfRangeException.ThrowIfZero(int, string?) - ArgumentOutOfRangeException.ThrowIfNegative(int, string?) - ArgumentOutOfRangeException.ThrowIfNegativeOrZero(int, string?) - ArgumentOutOfRangeException.ThrowIfEqual(T, T, string?) - ArgumentOutOfRangeException.ThrowIfNotEqual(T, T, string?) - ArgumentOutOfRangeException.ThrowIfGreaterThan(T, T, string?) - ArgumentOutOfRangeException.ThrowIfGreaterThanOrEqual(T, T, string?) - ArgumentOutOfRangeException.ThrowIfLessThan(T, T, string?) - ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(T, T, string?) - ObjectDisposedException.ThrowIf(bool, object) - ObjectDisposedException.ThrowIf(bool, Type) In addition, MSBuildTaskHost.csproj has been tweaked to only include the files in the Polyfills directory that it uses.

Use ArgumentException.ThrowIfNullOrEmpty in AbsolutePath and remove unneeded string resource, "PathMustNotBeNullOrEmpty" in favor of more general exception string.

src/Framework/Microsoft.Build.Framework.csproj

src/Package/MSBuild.VSSetup/files.swr

JanProvaznik

this is great, improves maintainability and fixes the localization for VS. I'm running an experimental insertion to get ahead of the possible dll count regression, so we can decide on timing of merge/if we should do something about that first

DustinCampbell · 2026-02-24T16:47:47Z

this is great, improves maintainability and fixes the localization for VS. I'm running an experimental insertion to get ahead of the possible dll count regression, so we can decide on timing of merge/if we should do something about that first

@JanProvaznik: Are there internal instructions for how to do test VS insertions with the MSBuild repo or a pipeline you could point me to? I'm happy to do these on my own to reduce cost on your end. Feel free to ping me over Teams if there's information.

rainersigwald · 2026-02-24T17:24:32Z

@DustinCampbell https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/50222/Experimental-SDK-insertion-in-VS

rainersigwald · 2026-02-24T17:37:37Z

No wait, that's the wrong scenario, shouldn't have tried to do this while talking to you 🙃

https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/44077/Infra?anchor=experimental-insertion

JanProvaznik · 2026-02-24T17:45:04Z

no Rainer, that link is for sdk insertion coming from VMR (and the second one assumes the person knows what they're doing 😄 )
for MSBuild I don't think there is a doc and I can create it now:

@DustinCampbell
https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/51067/how-to-experimentally-insert-MSBuild-to-VS

note for nonmicrosoft contributors:
it requires permissions, so I am not posting the full guide publicly and we'll do it ourselves in contributions that look promising and need it

…f* polyfills for exceptions (dotnet#13276) ### Summary - Modernize the string resources in `Microsoft.Build.Framework` and bring them in line with other dotnet repos. (01d840a) - Add various `Microsoft.Build.Framework.resources.dlls` to the `Localization` package, `VSSetup` and `VSSetup.Arm64`. (16c3145 and b89d070) - Add polyfills on non-.NET for `ThrowIf*` static methods on various exception types. (4b362f9) - Update `AbsolutePath` to use `ArgumentNullException.ThrowIfNull(...)` and `ArgumentException.ThrowIfNullOrEmpty(...)`. (c0f748b) Eventually, I intend to use the `ThrowIf*` polyfills throughout the MSBuild code base, which will allow several functions to be removed from `ErrorUtilities`. However, while wholly mechanical, that change will be pretty large, and I didn't want to pollute this pull request with all of that.

Copilot AI review requested due to automatic review settings February 20, 2026 23:59

Copilot started reviewing on behalf of DustinCampbell February 20, 2026 23:59 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

src/Framework/Polyfills/ArgumentExceptionExtensions.cs Show resolved Hide resolved

src/Framework.UnitTests/AbsolutePath_Tests.cs Outdated Show resolved Hide resolved

src/Framework.UnitTests/AbsolutePath_Tests.cs Outdated Show resolved Hide resolved

DustinCampbell added 6 commits February 20, 2026 16:45

Add MS.Build.Framework.resources.dlls to Localization nuspec

5c1bba8

Add MS.Build.Framework.resources.dlls to VSSetup and VSSetup.Arm64

e8947f0

Use ArgumentException.ThrowIfNullOrEmpty in AbsolutePath

77542ac

Use ArgumentException.ThrowIfNullOrEmpty in AbsolutePath and remove unneeded string resource, "PathMustNotBeNullOrEmpty" in favor of more general exception string.

Fix misspelled test method names

1ca1e44

DustinCampbell force-pushed the framework-string-resources branch from e7ce14c to 1ca1e44 Compare February 21, 2026 00:46

rainersigwald approved these changes Feb 23, 2026

View reviewed changes

src/Framework/Microsoft.Build.Framework.csproj Show resolved Hide resolved

src/Package/MSBuild.VSSetup/files.swr Show resolved Hide resolved

rainersigwald assigned JanProvaznik Feb 23, 2026

JanProvaznik approved these changes Feb 24, 2026

View reviewed changes

Merge branch 'main' into framework-string-resources

c96afa5

JanProvaznik merged commit 6fdc193 into dotnet:main Feb 24, 2026
10 checks passed

dotnet-maestro bot mentioned this pull request Feb 25, 2026

[main] Source code updates from dotnet/msbuild dotnet/dotnet#5071

Open

dotnet-maestro bot mentioned this pull request Feb 25, 2026

[release/11.0.1xx-preview2] Source code updates from dotnet/msbuild dotnet/dotnet#5058

Open

DustinCampbell deleted the framework-string-resources branch February 25, 2026 17:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rationalize Microsoft.Build.Framework string resources and add ThrowIf* polyfills for exceptions#13276

Rationalize Microsoft.Build.Framework string resources and add ThrowIf* polyfills for exceptions#13276
JanProvaznik merged 7 commits intodotnet:mainfrom
DustinCampbell:framework-string-resources

DustinCampbell commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JanProvaznik left a comment •

edited

Loading

Uh oh!

DustinCampbell commented Feb 24, 2026

Uh oh!

rainersigwald commented Feb 24, 2026

Uh oh!

rainersigwald commented Feb 24, 2026

Uh oh!

JanProvaznik commented Feb 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

DustinCampbell commented Feb 20, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JanProvaznik left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DustinCampbell commented Feb 24, 2026

Uh oh!

rainersigwald commented Feb 24, 2026

Uh oh!

rainersigwald commented Feb 24, 2026

Uh oh!

JanProvaznik commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JanProvaznik left a comment •

edited

Loading

JanProvaznik commented Feb 24, 2026 •

edited

Loading