Skip to content

Limited logging on Microsoft.DotNet.SignTool.SignToolTask crash #13254

@YuliiaKovalova

Description

@YuliiaKovalova

Description

During the work on the feature, the crash was reported on pipeline run with no repro locally:

D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\10.0.0-beta.26106.4\tools\Sign.proj(76,5): error MSB4018: The "Microsoft.DotNet.SignTool.SignToolTask" task failed unexpectedly.
System.Runtime.Serialization.SerializationException: Type 'System.AssemblyLoadEventArgs' in assembly 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' is not marked as serializable.
   at Microsoft.Build.BackEnd.Components.RequestBuilder.AssemblyLoadsTracker.CurrentDomainOnAssemblyLoad(Object sender, AssemblyLoadEventArgs args)
   at System.AppDomain.OnAssemblyLoadEvent(RuntimeAssembly LoadedAssembly)
   at Microsoft.Build.Framework.ITask.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\10.0.0-beta.26106.4\tools\Sign.proj]

The prerequisite was the file with SignToolTask expected to detect, but it was included for the specific platform:

Image

and Signing.props was searching for it all the time

Image

Fortunately, on vmr build a better error message was displayed:

 "Microsoft.DotNet.SignTool.SignToolTask" task failed unexpectedly.
   D:\a\_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(79,5): error MSB4018:
 System.IO.DirectoryNotFoundException: Could not find a part of the path
 'D:\a\_work\1\s\src\msbuild\artifacts\xsd\Update-MSBuildXsds.ps1'.
   D:\a\_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(79,5): error MSB4018:    at
  System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share,
 FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   D:\a\_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(79,5): error MSB4018:    at
  System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare
 share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   D:\a\_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(79,5): error MSB4018:    at
  System.IO.File.OpenRead(String path)
   D:\a\_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(79,5): error MSB4018:    at
  Microsoft.DotNet.SignTool.ContentUtil.GetContentHash(String fullPath) in
 /_/src/arcade/src/Microsoft.DotNet.SignTool/src/ContentUtil.cs:line 31
   D:\a\_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(79,5): error MSB4018:    at
  Microsoft.DotNet.SignTool.Configuration.GenerateListOfFiles() in
 /_/src/arcade/src/Microsoft.DotNet.SignTool/src/Configuration.cs:line 159
   D:\a\_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(79,5): error MSB4018:    at
  Microsoft.DotNet.SignTool.SignToolTask.ExecuteImpl() in
 /_/src/arcade/src/Microsoft.DotNet.SignTool/src/SignToolTask.cs:line 285
   D:\a\_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(79,5): error MSB4018:    at
  Microsoft.DotNet.SignTool.SignToolTask.Execute() in
 /_/src/arcade/src/Microsoft.DotNet.SignTool/src/SignToolTask.cs:line 189
   D:\a\_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(79,5): error MSB4018:    at
  Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext
  taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
       0 Warning(s)
       1 Error(s)

Expected Behavior:

Improve diagnosability on Task crash in MSBuild code .

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: DebuggabilityIssues impacting the diagnosability of builds, including logging and clearer error messages.Area: TasksIssues impacting the tasks shipped in Microsoft.Build.Tasks.Core.dll.internal-team-onboardingtriaged

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions