You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you attempt to fix a protected method in a sealed type that is not getting automatically set to override by using 'managedOverride'='override', the method will emitted as private.
This is because we attempt to fixup protected void Foo () { ... } in a sealed type when it isn't an override because it is a warning in C#.
However, this fixup does not take managedOverride into account.
If you attempt to fix a
protected
method in asealed
type that is not getting automatically set tooverride
by using'managedOverride'='override'
, the method will emitted asprivate
.This is because we attempt to fixup
protected void Foo () { ... }
in asealed
type when it isn't anoverride
because it is a warning in C#.However, this fixup does not take
managedOverride
into account.https://github.com/xamarin/java.interop/blob/main/tools/generator/Java.Interop.Tools.Generator.Transformation/SealedProtectedFixups.cs#L13-L14
We should see if the user has set
managedOverride
tooverride
, and if so, do not change the method toprivate
.The text was updated successfully, but these errors were encountered: