[Do Not Merge] Add Meter Tags, Instrument Tags, and Scopes to System Diagnostics Metrics #5624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kkeirstead/DC_Unification-PRFeedback
… Note that this operates under the assumption of unique meter names
…kkeirstead/TagsAndScopes
…kkeirstead/TagsAndScopes
src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/LiveMetricsTestConstants.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Nov 17, 2023
…ead/dotnet-monitor into kkeirstead/TagsAndScopes
wiktork
previously approved these changes
Nov 20, 2023
ghost
added
the
no-recent-activity
|
The 'no-recent-activity' label has been added to this pull request due to four weeks without any activity. If there is no activity in the next six weeks, this pull request will automatically be closed. You can learn more about our stale PR policy here: https://github.com/dotnet/dotnet-monitor/blob/main/CONTRIBUTING.md#stale-pr-policy |
schmittjoseph
removed
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR goes along with dotnet/diagnostics#4324 in the diagnostics repo.
Closes #5140
Release Notes Entry
Add Support for Meter Tags and Instrument Tags for System Diagnostics Metrics.