Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably unintended double negation #42621

Closed
mattiasnordqvist opened this issue Sep 15, 2024 · 1 comment
Closed

Probably unintended double negation #42621

mattiasnordqvist opened this issue Sep 15, 2024 · 1 comment
Labels
doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3

Comments

@mattiasnordqvist
Copy link

Type of issue

Typo

Description

image
Are these double negations intended?
Should I avoid to not "... use overloads that don't explicitly or implicitly specify the string comparison rules for string operations"?

Page URL

https://learn.microsoft.com/en-us/dotnet/standard/base-types/best-practices-strings

Content source URL

https://github.com/dotnet/docs/blob/main/docs/standard/base-types/best-practices-strings.md

Document Version Independent Id

fe538551-dcfc-c244-3f16-864d3f6c2a6e

Article author

@adegeo

Metadata

  • ID: dead2df6-1ec5-b55c-89aa-d05a7a75a0eb
  • Service: dotnet-fundamentals
@issues-automation issues-automation bot added dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 labels Sep 15, 2024
@dotnet-bot dotnet-bot added ⌚ Not Triaged Not triaged labels Sep 15, 2024
@adegeo adegeo added the doc-enhancement Improve the current content [org][type][category] label Sep 27, 2024
@adegeo
Copy link
Contributor

adegeo commented Sep 27, 2024

This one feels tough. I'm not totally sure for either side. Both ways would make sense to me, but if you were skimming the article you may be tripped up by a positive in the list of negatives. Each items also stands alone. I think it should remain as-is.

Some further thoughts:

You could merge both lists and introduce them appropriately:

  • Do ...
  • Do ..
  • Do ..
  • Do ..
  • Don't ...
  • Don't ...

However, their are a lot more Do than Don't, which may make it harder for the Don't to stand out, hence a paragraph break between the two lists.

If you wanted to open a pull request to adjust these, I'm fine with it, but I don't think this is a priority for us at the moment as I think it's clear enough. Thank you for the suggestion!

@adegeo adegeo closed this as completed Sep 27, 2024
@dotnetrepoman dotnetrepoman bot removed ⌚ Not Triaged Not triaged labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3
Projects
None yet
Development

No branches or pull requests

3 participants