Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCInfo deserializer once https://github.com/dotnet/runtime/pull/104336 merges #4795

Open
VSadov opened this issue Jul 16, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@VSadov
Copy link
Member

VSadov commented Jul 16, 2024

dotnet/runtime#104336 changes the encoding of GC info in a breaking way.
(arm/arm64 code offsets are encoded with fewer bits)

Once the runtime change goes in, the SOS copy will need to be updated correspondingly, to be able to dump from GcInfo v3

Re: dotnet/runtime#104336 (comment)

@tommcdon
Copy link
Member

Note: this change was reverted on dotnet/runtime#105234

@mikem8361
Copy link
Member

@VSadov is the reverted runtime change going to eventually make it into .NET 9? Can I change this issue to .NET 10?

@VSadov
Copy link
Member Author

VSadov commented Aug 29, 2024

Pushed out to dev10.
Sorry, I forgot to change this issue once it was clear it is not going to make it into 9.

@VSadov
Copy link
Member Author

VSadov commented Aug 29, 2024

Hmm, it does not look like i can change the milestone.

@mikem8361 mikem8361 modified the milestones: 9.0.0, 10.0.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants