Use new HelixAPI /job/{job}/results endpoint
#15230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
force-pushed
the
dev/simonrozsival/update-helix-apis
branch
from
2ef9460
to
024f116
Compare
3 tasks
chcosta
approved these changes
Nov 20, 2024
| [HelperMethod] | ||
| public string MaybeCallToString(TypeReference reference) | ||
| { | ||
| if (reference != TypeReference.String) |
There was a problem hiding this comment.
nit: I see this is only called in not null scenarios, but it still feels like a null check should occur in this method just in case someone else tries to consume this or someone tries to refactor the calling code and the check gets lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15229
Instead of relying on the SAS token returned in the new job response JSON, this PR uses the new Helix API endpoint to fetch the results URI and a short-lived SAS token for read access to the results.
To double check: