You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However as we don't know how many invocations and iterations it comprises of we cannot scale our stats correctly. Taking DiagnoserResults.TotalOperations is wrong here as it includes warmups and pilots, which we aren't measuring (and couldn't trivially measure in this way due to them being interleaved with other phases).
I'm a bit surprised to see the DiagnoserResults does not expose the actual run information from ExecuteResult - which it takes in its constructor. Doing so would allow people to come up with their own operation totals depending on their needs and measurement points.
Alternatively I would be helped with something like TotalWorkloadActualOperations but it feels like a slippery slope to add endless variations on data that should probably just be available in full fidelity.
The text was updated successfully, but these errors were encountered:
You could implement IExporter and get the results from the Summary.Reports and Report.AllMeasurements. You can also filter the measurements like .Where(m => m.Is(IterationMode.Workload, IterationStage.Actual).
[Edit] Although I'm not sure if you'll be able to add the results to the table, as I think the exporter runs after the diagnoser. Hm...
I was trying to implement a cpu diagnoser (i.e. #1666) however I ran into issues doing so as DiagnoserResults only exposes TotalOperations.
Taking a look at the gist: https://gist.github.com/MarkPflug/55173728458020c6d335cc099c891c0b
Specifically https://gist.github.com/MarkPflug/55173728458020c6d335cc099c891c0b#file-cpudiagnoser-cs-L54-L66
You can see it's measuring from before actual until the end of those runs (a contiguous measurement is needed).
This then gets emitted as metrics like so:
However as we don't know how many invocations and iterations it comprises of we cannot scale our stats correctly. Taking
DiagnoserResults.TotalOperations
is wrong here as it includes warmups and pilots, which we aren't measuring (and couldn't trivially measure in this way due to them being interleaved with other phases).I'm a bit surprised to see the DiagnoserResults does not expose the actual run information from ExecuteResult - which it takes in its constructor. Doing so would allow people to come up with their own operation totals depending on their needs and measurement points.
Alternatively I would be helped with something like
TotalWorkloadActualOperations
but it feels like a slippery slope to add endless variations on data that should probably just be available in full fidelity.The text was updated successfully, but these errors were encountered: