feat(menu): Add new Angular Tags portlet to /api/v1/menu and admin sidebar#34617
Open
hmoreras wants to merge 3 commits intoissue-33882-primeng-updatefrom
Open
feat(menu): Add new Angular Tags portlet to /api/v1/menu and admin sidebar#34617hmoreras wants to merge 3 commits intoissue-33882-primeng-updatefrom
hmoreras wants to merge 3 commits intoissue-33882-primeng-updatefrom
Conversation
…debar - Register 'tags-new' portlet in portlet.xml with PortletController and portlet-url /tags-new so the menu API returns the correct route for the migrated Angular tags portlet. - Add portlet title keys in Language.properties and Language_es.properties (com.dotcms.repackage.javax.portlet.title.tags-new) so the menu shows the correct label (Tags / Etiquetas). - Add TAGS_NEW to PortletID enum for consistent portlet id usage. - Add runonce Task260211AddTagsNewPortletToMenu to insert the tags-new portlet into the same layout as the legacy Tags portlet (Content Types group), so existing and new installations get the new portlet in the sidebar without manual DB changes. The Angular tags UI lives at /tags-new; without these changes it would not appear in the backend menu response or in the admin navigation. Co-authored-by: Cursor <cursoragent@cursor.com>
…acy as tags-legacy
- portlet.xml: legacy portlet id tags -> tags-legacy (display name Tag Manager unchanged).
Angular portlet id tags-new -> tags with portlet-url /tags.
- Language*.properties: title.tags for Angular, title.tags-legacy for legacy; remove tags-new.
- PortletID: remove TAGS_NEW, add TAGS_LEGACY("tags-legacy").
- app.routes.ts: path 'tags-new' -> 'tags' so Angular serves at /tags.
- Task260211: ensure tags (Angular) in menu, hide tags-legacy; migrate layout entries
tags-new -> tags, delete tags-legacy from layouts, add tags to Content Types if missing.
Co-authored-by: Cursor <cursoragent@cursor.com>
…ngular-portlet-to-menu
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. MPL-2.0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers the new Angular Tags portlet (
tags-new) so it appears in the backend menu API (/api/v1/menu) and in the admin sidebar, without requiring manual configuration.Problem
The Tags portlet was migrated to Angular and is served at
/tags-new, but it was not registered in the backend portlet configuration or in any layout. As a result, the menu API did not return an entry for it and the new portlet did not show up in the admin navigation.Solution
tags-newwithPortletControllerandportlet-url/tags-new, so the menu API returns the correct URL and the portlet is treated as Angular.com.dotcms.repackage.javax.portlet.title.tags-newinLanguage.propertiesandLanguage_es.propertiesso the menu displays the correct label (e.g. "Tags" / "Etiquetas").TAGS_NEW("tags-new")for consistent use of the portlet id.Task260211AddTagsNewPortletToMenuto insert thetags-newportlet into the same layout as the legacy Tags portlet (typically the "Content Types" group) on startup, so both new and existing installations get the new portlet in the sidebar.Testing
GET /api/v1/menushould include a menu item withid: "tags-new",url: "/tags-new", andangular: true.#32937