Skip to content

Builtin Date locale's methods ignore locale argument #572

@olegbespalov

Description

@olegbespalov

What?

One of the k6's users reported that using the Date().toLocaleDateString() always returns the date in the same format.

Date().toLocaleDateString('en-US') Expect 12/30/2012 : Actual 12/30/2012
Date().toLocaleDateString('en-CA') Expect 2012-12-30 : Actual 12/30/2012
Date().toLocaleDateString('en-GB') Expect 30/12/2012 : Actual 12/30/2012
Date().toLocaleDateString('de-DE') Expect 30.12.2012 : Actual 12/30/2012

It's happening since internally, the only dateLayout_en_GB is used, and we don't take into account any arguments.

Probably, that's not what most users will expect.

Why?

Fixing this will help satisfy users' expectations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions