Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification stops abruptly at target ratio, leading to non-uniform simplification #1314

Closed
marwie opened this issue Mar 15, 2024 · 2 comments
Labels
bug Something isn't working external Problems or limitations traced back to other tools. package:functions

Comments

@marwie
Copy link
Contributor

marwie commented Mar 15, 2024

Describe the bug
Hello, below is a video of a 100 vertices plane simplified with ratios [0.5, 0.25, 0.125, ...] and an error of 1

Expected behavior
Simplification is uniformly applied

Versions:

  • Version: 3.10.1
  • Environment: nodejs
20240315-101103_Min_-_Google_Chrome-logo.mp4
@marwie marwie added the bug Something isn't working label Mar 15, 2024
@donmccurdy
Copy link
Owner

@marwie — I think this will be outside of my control in glTF Transform, and would need to be reported on the meshoptimizer package. It may be expected behavior, it's not obvious to me whether the error metric is per-vertex or cumulative.

(and, I like your LOD videos a lot!)

@donmccurdy donmccurdy added dependencies Pull requests and issues related to dependencies package:functions labels Mar 15, 2024
@donmccurdy donmccurdy added external Problems or limitations traced back to other tools. and removed dependencies Pull requests and issues related to dependencies labels Mar 15, 2024
@marwie
Copy link
Contributor Author

marwie commented Mar 15, 2024

Thanks for the reply - I wasn't sure - opened an issue in the meshoptimizer repo now zeux/meshoptimizer#664

and thanks :)

@donmccurdy donmccurdy changed the title Simplifier: simplification seems to stop suddenly once error/ratio is reached resulting in partially simplified mesh Simplification stops abruptly at target ratio, leading to non-uniform simplification Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Problems or limitations traced back to other tools. package:functions
Projects
None yet
Development

No branches or pull requests

2 participants