Skip to content

Commit 153b098

Browse files
berrangeMarkus Armbruster
authored andcommitted
qapi: Move and rename qapi/qmp/dispatch.h to qapi/qmp-registry.h
The general expectation is that header files should follow the same file/path naming scheme as the corresponding source file. There are various historical exceptions to this practice in QEMU, with one of the most notable being the include/qapi/qmp/ directory. include/qapi/qmp/dispatch.h corresponds mostly to qapi/qmp-registry.c. Move and rename it to include/qapi/qmp-registry.h. Now just qerror.h is left in include/qapi/qmp/. Since it's deprecated & (slowly) getting eliminated anyway, it isn't worth moving. Signed-off-by: Daniel P. Berrangé <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Signed-off-by: Markus Armbruster <[email protected]> Message-ID: <[email protected]>
1 parent 407bc4b commit 153b098

File tree

10 files changed

+9
-9
lines changed

10 files changed

+9
-9
lines changed

docs/devel/qapi-code-gen.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1855,7 +1855,7 @@ Example::
18551855
#ifndef EXAMPLE_QAPI_INIT_COMMANDS_H
18561856
#define EXAMPLE_QAPI_INIT_COMMANDS_H
18571857

1858-
#include "qapi/qmp/dispatch.h"
1858+
#include "qapi/qmp-registry.h"
18591859

18601860
void example_qmp_init_marshal(QmpCommandList *cmds);
18611861

monitor/monitor-internal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#include "chardev/char-fe.h"
2929
#include "monitor/monitor.h"
3030
#include "qapi/qapi-types-control.h"
31-
#include "qapi/qmp/dispatch.h"
31+
#include "qapi/qmp-registry.h"
3232
#include "qobject/json-parser.h"
3333
#include "qemu/readline.h"
3434
#include "system/iothread.h"

qapi/qmp-dispatch.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
#include "block/aio.h"
1717
#include "qapi/compat-policy.h"
1818
#include "qapi/error.h"
19-
#include "qapi/qmp/dispatch.h"
19+
#include "qapi/qmp-registry.h"
2020
#include "qobject/qdict.h"
2121
#include "qobject/qjson.h"
2222
#include "qapi/qobject-input-visitor.h"

qapi/qmp-registry.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
*/
1414

1515
#include "qemu/osdep.h"
16-
#include "qapi/qmp/dispatch.h"
16+
#include "qapi/qmp-registry.h"
1717

1818
void qmp_register_command(QmpCommandList *cmds, const char *name,
1919
QmpCommandFunc *fn, QmpCommandOptions options,

qga/guest-agent-core.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#ifndef GUEST_AGENT_CORE_H
1414
#define GUEST_AGENT_CORE_H
1515

16-
#include "qapi/qmp/dispatch.h"
16+
#include "qapi/qmp-registry.h"
1717
#include "qga-qapi-types.h"
1818

1919
#define QGA_READ_COUNT_DEFAULT 4096

scripts/qapi/commands.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ def _begin_user_module(self, name: str) -> None:
346346
def visit_begin(self, schema: QAPISchema) -> None:
347347
self._add_module('./init', ' * QAPI Commands initialization')
348348
self._genh.add(mcgen('''
349-
#include "qapi/qmp/dispatch.h"
349+
#include "qapi/qmp-registry.h"
350350
351351
void %(c_prefix)sqmp_init_marshal(QmpCommandList *cmds);
352352
''',

stubs/qmp-command-available.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#include "qemu/osdep.h"
2-
#include "qapi/qmp/dispatch.h"
2+
#include "qapi/qmp-registry.h"
33

44
bool qmp_command_available(const QmpCommand *cmd, Error **errp)
55
{

stubs/qmp-quit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#include "qemu/osdep.h"
22
#include "qapi/qapi-commands-control.h"
3-
#include "qapi/qmp/dispatch.h"
3+
#include "qapi/qmp-registry.h"
44

55
void qmp_quit(Error **errp)
66
{

system/qdev-monitor.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
#include "system/runstate.h"
2727
#include "qapi/error.h"
2828
#include "qapi/qapi-commands-qdev.h"
29-
#include "qapi/qmp/dispatch.h"
29+
#include "qapi/qmp-registry.h"
3030
#include "qobject/qdict.h"
3131
#include "qapi/qmp/qerror.h"
3232
#include "qobject/qstring.h"

0 commit comments

Comments
 (0)