Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitivity for all worksheets in the Excel workbook #814

Closed
kdahlquist opened this issue Nov 21, 2019 · 3 comments
Closed

Case-insensitivity for all worksheets in the Excel workbook #814

kdahlquist opened this issue Nov 21, 2019 · 3 comments

Comments

@kdahlquist
Copy link
Collaborator

Issue #732 addressed the case of sheet names being case-insensitive for the "network" sheet. However, we need to decide and then implement if we will allow other sheet names to be case-insensitive as well.

I believe GRNmap is going to expect them to be all lower case (but I would need to verify that). When GRNmap outputs files, it does make all the names lower case.

It is in the situation where users are making Excel workbooks from scratch that this will come up.

One of the downstream applications of the Export to Excel function is to act as in input workbook validator for GRNmap. For example, if a user uploads a workbook that has "Network" instead of "network" for the network sheet, GRNsight will accept it, but fix the tense upon export.

I don't know if this is something we have time to do before the end of the semester. Because it involves changing formats, I want to make sure that have all the proper tests in place.

@mihirsamdarshi
Copy link
Collaborator

case-insensitivity was implemented for network_optimized_weights sheets when the change for the network sheet was made

@kdahlquist kdahlquist self-assigned this Nov 2, 2022
@kdahlquist
Copy link
Collaborator Author

@kdahlquist should look into this one and see if it can be closed.

@kdahlquist
Copy link
Collaborator Author

backlogging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants