Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When GRN loaded from file with no expression data, nodes are colored gray instead of white #1074

Closed
kdahlquist opened this issue Nov 28, 2023 · 8 comments

Comments

@kdahlquist
Copy link
Collaborator

Do this:

  • upload an unweighted GRN from a file with no expression data
  • nodes are colored gray instead of white

Need to check to see if this also happens with a weighted network.

@akaiap
Copy link
Collaborator

akaiap commented Apr 9, 2024

After completing onboarding, this past week I have been familiarizing myself with the code regarding this issue and I have had some observations:

The nodes being colored gray instead of white is likely due to the absence of expression data, which is used to determine node colors. However, I am wondering if it's a more general issue with the node coloring mechanism.

In _server/controllers/workbook-constants.js I saw a detailed warning with the following details:
Warning Code: MISSING_EXPRESSION_SHEET Error Description: The '_log2_expression' or '_log2_optimized_expression' worksheet was not found in the uploaded file. These worksheets likely contain expression data used for node coloring in the network graph. Since the data is missing, the nodes will be displayed without color.

Instructions read: To resolve this issue, users can follow these instructions: Add the missing '_log2_expression' or '_log2_optimized_expression' worksheets to the Excel workbook containing the expression data. Then, select expression data from GRNsight's Expression Database, accessible from the Node menu or panel. Addressing these nuances in the codebase will contribute to enhancing the functionality and user experience of the application.

@kdahlquist
Copy link
Collaborator Author

The users should be able to upload a workbook without the "_log2_expression" or "log2_optimized_expression" worksheets. That's why it is a warning instead of an error (an error doesn't allow the graph to display).

In the case that they are missing these worksheets, the nodes should display as white, not gray.

@dondi
Copy link
Owner

dondi commented Apr 9, 2024

Suggested sequence for approaching this:

  • Locate the code in GRNsight that chooses a node’s fill color
  • Insert some logging/study the logic to determine why the gray color appears
  • When this is tracked down fully, that’s when we can determine how to solve it

@dondi
Copy link
Owner

dondi commented Apr 9, 2024

Possible place to look, as determined from the meeting: https://github.com/dondi/GRNsight/blob/beta/web-client/public/js/graph.js#L1131-L1137

@akaiap akaiap mentioned this issue Oct 2, 2024
41 tasks
@dondi dondi assigned ntran18 and unassigned akaiap Oct 30, 2024
@ntran18
Copy link
Collaborator

ntran18 commented Oct 30, 2024

When #1080 is merged to beta, @dondi can confirm if this issue is fixed

@dondi
Copy link
Owner

dondi commented Nov 13, 2024

Actually unable to replicate, even in production anymore. Need to check w/ team

@dondi
Copy link
Owner

dondi commented Nov 13, 2024

Update: the gray color can be seen in production by activating node coloring on a PPI. This no longer happens in beta, because due to #1068 node coloring now activates correctly

@kdahlquist
Copy link
Collaborator Author

This issue is no longer appearing because when a user uploads a file with no expression data, the nodes get colored with data from GRNsight's expression database. Beta 7.1.7 However, this creates the question of whether we want this to be the default behavior. Started new issue #1144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants