-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When GRN loaded from file with no expression data, nodes are colored gray instead of white #1074
Comments
After completing onboarding, this past week I have been familiarizing myself with the code regarding this issue and I have had some observations: The nodes being colored gray instead of white is likely due to the absence of expression data, which is used to determine node colors. However, I am wondering if it's a more general issue with the node coloring mechanism. In _server/controllers/workbook-constants.js I saw a detailed warning with the following details: Instructions read: To resolve this issue, users can follow these instructions: Add the missing '_log2_expression' or '_log2_optimized_expression' worksheets to the Excel workbook containing the expression data. Then, select expression data from GRNsight's Expression Database, accessible from the Node menu or panel. Addressing these nuances in the codebase will contribute to enhancing the functionality and user experience of the application. |
The users should be able to upload a workbook without the "_log2_expression" or "log2_optimized_expression" worksheets. That's why it is a warning instead of an error (an error doesn't allow the graph to display). In the case that they are missing these worksheets, the nodes should display as white, not gray. |
Suggested sequence for approaching this:
|
Possible place to look, as determined from the meeting: https://github.com/dondi/GRNsight/blob/beta/web-client/public/js/graph.js#L1131-L1137 |
Actually unable to replicate, even in production anymore. Need to check w/ team |
Update: the gray color can be seen in production by activating node coloring on a PPI. This no longer happens in |
This issue is no longer appearing because when a user uploads a file with no expression data, the nodes get colored with data from GRNsight's expression database. Beta 7.1.7 However, this creates the question of whether we want this to be the default behavior. Started new issue #1144. |
Do this:
Need to check to see if this also happens with a weighted network.
The text was updated successfully, but these errors were encountered: