Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate Network mode at all times #1067

Open
dondi opened this issue Nov 14, 2023 · 3 comments
Open

Activate Network mode at all times #1067

dondi opened this issue Nov 14, 2023 · 3 comments

Comments

@dondi
Copy link
Owner

dondi commented Nov 14, 2023

The Network Mode switch should permeate more of the app, controlling any functions that will differ based on whether GRNs and PPIs are involved:

  • menu item should be available when GRNsight first loads
  • then it would affect which file types are allowed in the Open File menu and which default network type comes up in the Load from Database modal.
  • When “Load from Database” is chosen, the Network Type dropdown can default to whatever the currently-selected Network Mode is from the main UI
@dondi
Copy link
Owner Author

dondi commented Nov 21, 2023

The second bullet in the description may need discussion alongside #1066 request to have the opened file determine the network mode

@dondi
Copy link
Owner Author

dondi commented Nov 21, 2023

Upon discussion, we can go ahead and eliminate the second bullet from scope in favor of #1066 but we will still enable the Network Mode dropdown for informational purposes—switching it even when there is no network open should enable/disable other corresponding options based on network type

@ntran18
Copy link
Collaborator

ntran18 commented Nov 27, 2024

The second and third issues are addressed in PR #1087. Enabling network mode by default will be resolved once issue #1152 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants